Skip to content

Conversation

goutamvenkat-anyscale
Copy link
Contributor

@goutamvenkat-anyscale goutamvenkat-anyscale commented Jul 3, 2025

Why are these changes needed?

Adding with_columns API to enable users to pass in multiple expressions, that can get bundled into a single Project call.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@goutamvenkat-anyscale goutamvenkat-anyscale requested a review from a team as a code owner July 3, 2025 18:57
@goutamvenkat-anyscale goutamvenkat-anyscale added the go add ONLY when ready to merge, run all tests label Jul 7, 2025
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
@goutamvenkat-anyscale goutamvenkat-anyscale changed the title Add Expression Support & with_columns API [Data] Add Expression Support & with_columns API Jul 7, 2025
@goutamvenkat-anyscale goutamvenkat-anyscale added the data Ray Data-related issues label Jul 7, 2025
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
# ──────────────────────────────────────
# This is used by Dataset.with_columns – kept here so it can be re-used by
# future optimised executors.
_PANDAS_OPS: Dict[str, Callable[[Any, Any], Any]] = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if these pandas, numpy, and pyarrow all need to have keys for "add", "sub", etc.. maybe better to define a base class for each key, and then implement __call__ for each subclass (pandas, numpy, pyarrow)?

Copy link
Contributor

@alexeykudinkin alexeykudinkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address comments before landing

@alexeykudinkin alexeykudinkin enabled auto-merge (squash) July 11, 2025 20:01
Signed-off-by: Goutam V <[email protected]>
@github-actions github-actions bot disabled auto-merge July 11, 2025 23:23
@alexeykudinkin alexeykudinkin merged commit 0cebaa1 into ray-project:master Jul 12, 2025
5 checks passed
jugalshah291 pushed a commit to jugalshah291/ray_fork that referenced this pull request Sep 11, 2025
dstrodtman pushed a commit to dstrodtman/ray that referenced this pull request Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data Ray Data-related issues go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants