-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[Data] Add Expression Support & with_columns API #54322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data] Add Expression Support & with_columns API #54322
Conversation
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
a8807e8
to
9a5086f
Compare
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
python/ray/data/expressions.py
Outdated
# ────────────────────────────────────── | ||
# This is used by Dataset.with_columns – kept here so it can be re-used by | ||
# future optimised executors. | ||
_PANDAS_OPS: Dict[str, Callable[[Any, Any], Any]] = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if these pandas, numpy, and pyarrow all need to have keys for "add", "sub", etc.. maybe better to define a base class for each key, and then implement __call__
for each subclass (pandas, numpy, pyarrow)?
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address comments before landing
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: Goutam V <[email protected]>
Signed-off-by: jugalshah291 <[email protected]>
Signed-off-by: Douglas Strodtman <[email protected]>
Why are these changes needed?
Adding
with_columns
API to enable users to pass in multiple expressions, that can get bundled into a singleProject
call.Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.