-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[wheel] mac: upgrade arm64 wheel to macos 12 #54323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Upgrades both Intel and Apple Silicon macOS wheels to target macOS 12.0, updating filename logic, documentation, and CI tests.
- Updated
get_wheel_filenameto emitmacosx_12_0_*tags for both architectures. - Refreshed installation docs with new ARM64 wheel URLs.
- Adjusted CI test expectations and supported OS list in wheel utilities.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| python/ray/_private/utils.py | Changed darwin wheel tags to macosx_12_0_*. |
| doc/source/ray-overview/installation.rst | Updated ARM64 nightly wheel links to macOS 12. |
| ci/ray_ci/automation/test_ray_wheels_lib.py | Aligned expected wheel names with macOS 12 tag. |
| ci/ray_ci/automation/test_pypi_lib.py | Updated ray_cpp wheel names to macOS 12 tag. |
| ci/ray_ci/automation/ray_wheels_lib.py | Replaced macosx_11_0_arm64 with macosx_12_0_arm64. |
|
we have upgrade all macos apple silicon AMI's on CI to use macos 12 now. |
04c0156 to
c9ac8de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
osx 11 released november 2020, this is effectively making the lower bound 12 right. Do we need to make any announcement anywhere? Maybe just remember to put it in release notes?
yes, this raises the lower bound. I can make an announcement and mention it in the release notes. even macos 12 / monterey is already out of its support lifecycle already. macos typically has a lifecycle that spans 3 years. |
now wheels for both intel and apple silicon are on the same version `ray[all]` does not work on arm64 macos 11 anyways, as `scipy` does not have the related wheels Signed-off-by: Lonnie Liu <[email protected]>
c9ac8de to
2b485af
Compare
now wheels for both intel and apple silicon are on the same version `ray[all]` does not work on arm64 macos 11 anyways, as `scipy` does not have the related wheels Signed-off-by: Lonnie Liu <[email protected]> Signed-off-by: elliot-barn <[email protected]>
now wheels for both intel and apple silicon are on the same version `ray[all]` does not work on arm64 macos 11 anyways, as `scipy` does not have the related wheels Signed-off-by: Lonnie Liu <[email protected]> Signed-off-by: ChanChan Mao <[email protected]>
now wheels for both intel and apple silicon are on the same version `ray[all]` does not work on arm64 macos 11 anyways, as `scipy` does not have the related wheels Signed-off-by: Lonnie Liu <[email protected]> Signed-off-by: Douglas Strodtman <[email protected]>
now wheels for both intel and apple silicon are on the same version
ray[all]does not work on arm64 macos 11 anyways, asscipydoes not have the related wheels