reduce number of loops over request headers from 2 to 1 #54326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abrar <[email protected]>
Signed-off-by: abrar <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes header handling by cutting out an extra loop over headers, consolidating existence check and retrieval into a single operation.
- Uses
headers.getto check for and retrieve the request ID in one pass. - Generates and appends a new request ID only when it's missing.
zcin
reviewed
Jul 3, 2025
Signed-off-by: abrar <[email protected]>
zcin
approved these changes
Jul 4, 2025
ccmao1130
pushed a commit
to ccmao1130/ray
that referenced
this pull request
Jul 29, 2025
…54326) `__getitem__` on headers is a O(n) operation. Optimize the code to cut out the extra loop. --------- Signed-off-by: abrar <[email protected]> Signed-off-by: ChanChan Mao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__getitem__on headers is a O(n) operation. Optimize the code to cut out the extra loop.