Skip to content

Conversation

@dayshah
Copy link
Contributor

@dayshah dayshah commented Jul 8, 2025

Why are these changes needed?

This scheduling queue unit test would take >30 seconds before because the default value of reorder_wait_seconds is 30. Now just injecting it in one level higher so can inject it into the test as 1 second.

Copilot AI review requested due to automatic review settings July 8, 2025 06:22
@dayshah dayshah added the go add ONLY when ready to merge, run all tests label Jul 8, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes the reorder_wait_seconds for actor scheduling queues injectable so tests can run with a reduced timeout (1s instead of the default 30s).

  • Exposed reorder_wait_seconds as a constructor parameter in ActorSchedulingQueue
  • Updated TaskReceiver to pass the config value into the new queue constructor
  • Modified all scheduling queue tests to inject a 1-second reorder wait

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/ray/core_worker/transport/task_receiver.cc Passes actor_scheduling_queue_max_reorder_wait_seconds() into ActorSchedulingQueue
src/ray/core_worker/transport/actor_scheduling_queue.h Added reorder_wait_seconds parameter and member
src/ray/core_worker/transport/actor_scheduling_queue.cc Updated constructor signature and initializer list
src/ray/core_worker/test/scheduling_queue_test.cc Injects a 1-second reorder_wait_seconds in tests
Comments suppressed due to low confidence (2)

src/ray/core_worker/transport/actor_scheduling_queue.h:49

  • [nitpick] Add or update the constructor doc comment above this line to describe the new reorder_wait_seconds parameter, so callers know its purpose and units.
      int64_t reorder_wait_seconds);

src/ray/core_worker/test/scheduling_queue_test.cc:340

  • [nitpick] Re-add a comment explaining why io_service.run() is invoked here (e.g., "// immediately triggers the reordered-task timeout") to preserve test intent clarity.
  io_service.run();

@edoakes edoakes merged commit de8a257 into ray-project:master Jul 8, 2025
4 checks passed
@dayshah dayshah deleted the 30s-scheduling-queue-test branch July 8, 2025 15:25
landscapepainter pushed a commit to landscapepainter/ray that referenced this pull request Jul 9, 2025
…ject#54404)

This scheduling queue unit test would take >30 seconds before because
the default value of reorder_wait_seconds is 30. Now just injecting it
in one level higher so can inject it into the test as 1 second.

Signed-off-by: dayshah <[email protected]>
Signed-off-by: doyoung <[email protected]>
landscapepainter pushed a commit to landscapepainter/ray that referenced this pull request Jul 9, 2025
…ject#54404)

This scheduling queue unit test would take >30 seconds before because
the default value of reorder_wait_seconds is 30. Now just injecting it
in one level higher so can inject it into the test as 1 second.

Signed-off-by: dayshah <[email protected]>
Signed-off-by: doyoung <[email protected]>
ccmao1130 pushed a commit to ccmao1130/ray that referenced this pull request Jul 29, 2025
…ject#54404)

This scheduling queue unit test would take >30 seconds before because
the default value of reorder_wait_seconds is 30. Now just injecting it
in one level higher so can inject it into the test as 1 second.

Signed-off-by: dayshah <[email protected]>
Signed-off-by: ChanChan Mao <[email protected]>
dstrodtman pushed a commit to dstrodtman/ray that referenced this pull request Oct 6, 2025
…ject#54404)

This scheduling queue unit test would take >30 seconds before because
the default value of reorder_wait_seconds is 30. Now just injecting it
in one level higher so can inject it into the test as 1 second.

Signed-off-by: dayshah <[email protected]>
Signed-off-by: Douglas Strodtman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants