[wheel] remove pyarrow <18 restriction #54405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the restriction should be on installation time rather than inside the wheel. this extra constraint sometimes can unnecessarily mislead depedency manager's resolution algorithms Signed-off-by: Lonnie Liu <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR removes the hardcoded macOS x86_64 pyarrow <18 constraint from the wheel metadata and shifts the version restriction to installation time.
- Drops the platform-specific
<18pin fromsetup.pyextras - Cleans up the corresponding lines in
requirements.txt
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| python/setup.py | Removed the pyarrow <18; sys_platform == 'darwin' and platform_machine == 'x86_64' extra dependency |
| python/requirements.txt | Deleted the macOS constraint comment and <18 pin, leaving pyarrow >= 9.0.0 |
Comments suppressed due to low confidence (1)
python/requirements.txt:26
- [nitpick] Consider re-adding a brief comment or updating the project documentation to explain why the macOS
<18constraint was removed, so future maintainers understand the rationale.
pyarrow >= 9.0.0
|
might resolve the issue surfaced in #52820 |
|
this means that we might need to pin to a specific version during testing |
|
cc @justinvyu |
elliot-barn
approved these changes
Jul 8, 2025
|
all macos CI test passed: the retries were due to the routine machine reset last night. |
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Jul 9, 2025
the restriction should be on installation time rather than inside the wheel. this extra constraint sometimes can unnecessarily mislead depedency manager's resolution algorithms Signed-off-by: Lonnie Liu <[email protected]> Signed-off-by: doyoung <[email protected]>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Jul 9, 2025
the restriction should be on installation time rather than inside the wheel. this extra constraint sometimes can unnecessarily mislead depedency manager's resolution algorithms Signed-off-by: Lonnie Liu <[email protected]> Signed-off-by: doyoung <[email protected]>
ccmao1130
pushed a commit
to ccmao1130/ray
that referenced
this pull request
Jul 29, 2025
the restriction should be on installation time rather than inside the wheel. this extra constraint sometimes can unnecessarily mislead depedency manager's resolution algorithms Signed-off-by: Lonnie Liu <[email protected]> Signed-off-by: ChanChan Mao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the restriction should be on installation time rather than inside the wheel. this extra constraint sometimes can unnecessarily mislead depedency manager's resolution algorithms