Skip to content

Conversation

@abrarsheikh
Copy link
Contributor

@abrarsheikh abrarsheikh commented Aug 22, 2025

  1. rank and world_size are now available on ReplicaContext.
  2. Replica initialization now requires providing a rank
  3. Any change to the replicas rank will be communicated from controller via .reconfigure() method.
  4. Assigned rank to replica can be fetched from get_metadata() function, this will be useful during controller recovery to reconstruct the state.

This PR fills in a dummy rank value, in the future PR we will fetch the replica from DeploymentRankManager and pass in the correct value.

Part 2 of #54938

Next diff in pipeline #55829

@abrarsheikh abrarsheikh added the go add ONLY when ready to merge, run all tests label Aug 22, 2025
@abrarsheikh abrarsheikh marked this pull request as ready for review August 22, 2025 15:40
@abrarsheikh abrarsheikh requested a review from a team as a code owner August 22, 2025 15:40
@ray-gardener ray-gardener bot added the serve Ray Serve Related Issue label Aug 22, 2025
@zcin zcin merged commit 90230ce into master Aug 28, 2025
6 checks passed
@zcin zcin deleted the SERVE-991-abrar-rank_p2 branch August 28, 2025 00:22
tohtana pushed a commit to tohtana/ray that referenced this pull request Aug 29, 2025
1. `rank` and `world_size` are now available on `ReplicaContext`.
2. Replica initialization now requires providing a rank
3. Any change to the replicas rank will be communicated from controller
via `.reconfigure()` method.
4. Assigned rank to replica can be fetched from `get_metadata()`
function, this will be useful during controller recovery to reconstruct
the state.

This PR fills in a dummy rank value, in the future PR we will fetch the
replica from DeploymentRankManager and pass in the correct value.

Part 2 of ray-project#54938

Next diff in pipeline ray-project#55829

---------

Signed-off-by: abrar <[email protected]>
Signed-off-by: Masahiro Tanaka <[email protected]>
tohtana pushed a commit to tohtana/ray that referenced this pull request Aug 29, 2025
1. `rank` and `world_size` are now available on `ReplicaContext`.
2. Replica initialization now requires providing a rank
3. Any change to the replicas rank will be communicated from controller
via `.reconfigure()` method.
4. Assigned rank to replica can be fetched from `get_metadata()`
function, this will be useful during controller recovery to reconstruct
the state.

This PR fills in a dummy rank value, in the future PR we will fetch the
replica from DeploymentRankManager and pass in the correct value.

Part 2 of ray-project#54938

Next diff in pipeline ray-project#55829

---------

Signed-off-by: abrar <[email protected]>
Signed-off-by: Masahiro Tanaka <[email protected]>
gangsf pushed a commit to gangsf/ray that referenced this pull request Sep 2, 2025
1. `rank` and `world_size` are now available on `ReplicaContext`.
2. Replica initialization now requires providing a rank
3. Any change to the replicas rank will be communicated from controller
via `.reconfigure()` method.
4. Assigned rank to replica can be fetched from `get_metadata()`
function, this will be useful during controller recovery to reconstruct
the state.

This PR fills in a dummy rank value, in the future PR we will fetch the
replica from DeploymentRankManager and pass in the correct value.

Part 2 of ray-project#54938

Next diff in pipeline ray-project#55829

---------

Signed-off-by: abrar <[email protected]>
Signed-off-by: Gang Zhao <[email protected]>
sampan-s-nayak pushed a commit to sampan-s-nayak/ray that referenced this pull request Sep 8, 2025
1. `rank` and `world_size` are now available on `ReplicaContext`.
2. Replica initialization now requires providing a rank
3. Any change to the replicas rank will be communicated from controller
via `.reconfigure()` method.
4. Assigned rank to replica can be fetched from `get_metadata()`
function, this will be useful during controller recovery to reconstruct
the state.

This PR fills in a dummy rank value, in the future PR we will fetch the
replica from DeploymentRankManager and pass in the correct value.

Part 2 of ray-project#54938

Next diff in pipeline ray-project#55829

---------

Signed-off-by: abrar <[email protected]>
Signed-off-by: sampan <[email protected]>
jugalshah291 pushed a commit to jugalshah291/ray_fork that referenced this pull request Sep 11, 2025
1. `rank` and `world_size` are now available on `ReplicaContext`.
2. Replica initialization now requires providing a rank
3. Any change to the replicas rank will be communicated from controller
via `.reconfigure()` method.
4. Assigned rank to replica can be fetched from `get_metadata()`
function, this will be useful during controller recovery to reconstruct
the state.

This PR fills in a dummy rank value, in the future PR we will fetch the
replica from DeploymentRankManager and pass in the correct value.

Part 2 of ray-project#54938

Next diff in pipeline ray-project#55829

---------

Signed-off-by: abrar <[email protected]>
Signed-off-by: jugalshah291 <[email protected]>
dstrodtman pushed a commit that referenced this pull request Oct 6, 2025
1. `rank` and `world_size` are now available on `ReplicaContext`.
2. Replica initialization now requires providing a rank
3. Any change to the replicas rank will be communicated from controller
via `.reconfigure()` method.
4. Assigned rank to replica can be fetched from `get_metadata()`
function, this will be useful during controller recovery to reconstruct
the state.

This PR fills in a dummy rank value, in the future PR we will fetch the
replica from DeploymentRankManager and pass in the correct value.

Part 2 of #54938

Next diff in pipeline #55829

---------

Signed-off-by: abrar <[email protected]>
Signed-off-by: Douglas Strodtman <[email protected]>
landscapepainter pushed a commit to landscapepainter/ray that referenced this pull request Nov 17, 2025
1. `rank` and `world_size` are now available on `ReplicaContext`.
2. Replica initialization now requires providing a rank
3. Any change to the replicas rank will be communicated from controller
via `.reconfigure()` method.
4. Assigned rank to replica can be fetched from `get_metadata()`
function, this will be useful during controller recovery to reconstruct
the state.

This PR fills in a dummy rank value, in the future PR we will fetch the
replica from DeploymentRankManager and pass in the correct value.

Part 2 of ray-project#54938

Next diff in pipeline ray-project#55829

---------

Signed-off-by: abrar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests serve Ray Serve Related Issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants