-
Notifications
You must be signed in to change notification settings - Fork 7k
Add rank and world size in replica context #55827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abrar <[email protected]>
Signed-off-by: abrar <[email protected]>
zcin
reviewed
Aug 26, 2025
zcin
approved these changes
Aug 28, 2025
tohtana
pushed a commit
to tohtana/ray
that referenced
this pull request
Aug 29, 2025
1. `rank` and `world_size` are now available on `ReplicaContext`. 2. Replica initialization now requires providing a rank 3. Any change to the replicas rank will be communicated from controller via `.reconfigure()` method. 4. Assigned rank to replica can be fetched from `get_metadata()` function, this will be useful during controller recovery to reconstruct the state. This PR fills in a dummy rank value, in the future PR we will fetch the replica from DeploymentRankManager and pass in the correct value. Part 2 of ray-project#54938 Next diff in pipeline ray-project#55829 --------- Signed-off-by: abrar <[email protected]> Signed-off-by: Masahiro Tanaka <[email protected]>
tohtana
pushed a commit
to tohtana/ray
that referenced
this pull request
Aug 29, 2025
1. `rank` and `world_size` are now available on `ReplicaContext`. 2. Replica initialization now requires providing a rank 3. Any change to the replicas rank will be communicated from controller via `.reconfigure()` method. 4. Assigned rank to replica can be fetched from `get_metadata()` function, this will be useful during controller recovery to reconstruct the state. This PR fills in a dummy rank value, in the future PR we will fetch the replica from DeploymentRankManager and pass in the correct value. Part 2 of ray-project#54938 Next diff in pipeline ray-project#55829 --------- Signed-off-by: abrar <[email protected]> Signed-off-by: Masahiro Tanaka <[email protected]>
gangsf
pushed a commit
to gangsf/ray
that referenced
this pull request
Sep 2, 2025
1. `rank` and `world_size` are now available on `ReplicaContext`. 2. Replica initialization now requires providing a rank 3. Any change to the replicas rank will be communicated from controller via `.reconfigure()` method. 4. Assigned rank to replica can be fetched from `get_metadata()` function, this will be useful during controller recovery to reconstruct the state. This PR fills in a dummy rank value, in the future PR we will fetch the replica from DeploymentRankManager and pass in the correct value. Part 2 of ray-project#54938 Next diff in pipeline ray-project#55829 --------- Signed-off-by: abrar <[email protected]> Signed-off-by: Gang Zhao <[email protected]>
sampan-s-nayak
pushed a commit
to sampan-s-nayak/ray
that referenced
this pull request
Sep 8, 2025
1. `rank` and `world_size` are now available on `ReplicaContext`. 2. Replica initialization now requires providing a rank 3. Any change to the replicas rank will be communicated from controller via `.reconfigure()` method. 4. Assigned rank to replica can be fetched from `get_metadata()` function, this will be useful during controller recovery to reconstruct the state. This PR fills in a dummy rank value, in the future PR we will fetch the replica from DeploymentRankManager and pass in the correct value. Part 2 of ray-project#54938 Next diff in pipeline ray-project#55829 --------- Signed-off-by: abrar <[email protected]> Signed-off-by: sampan <[email protected]>
jugalshah291
pushed a commit
to jugalshah291/ray_fork
that referenced
this pull request
Sep 11, 2025
1. `rank` and `world_size` are now available on `ReplicaContext`. 2. Replica initialization now requires providing a rank 3. Any change to the replicas rank will be communicated from controller via `.reconfigure()` method. 4. Assigned rank to replica can be fetched from `get_metadata()` function, this will be useful during controller recovery to reconstruct the state. This PR fills in a dummy rank value, in the future PR we will fetch the replica from DeploymentRankManager and pass in the correct value. Part 2 of ray-project#54938 Next diff in pipeline ray-project#55829 --------- Signed-off-by: abrar <[email protected]> Signed-off-by: jugalshah291 <[email protected]>
dstrodtman
pushed a commit
that referenced
this pull request
Oct 6, 2025
1. `rank` and `world_size` are now available on `ReplicaContext`. 2. Replica initialization now requires providing a rank 3. Any change to the replicas rank will be communicated from controller via `.reconfigure()` method. 4. Assigned rank to replica can be fetched from `get_metadata()` function, this will be useful during controller recovery to reconstruct the state. This PR fills in a dummy rank value, in the future PR we will fetch the replica from DeploymentRankManager and pass in the correct value. Part 2 of #54938 Next diff in pipeline #55829 --------- Signed-off-by: abrar <[email protected]> Signed-off-by: Douglas Strodtman <[email protected]>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
1. `rank` and `world_size` are now available on `ReplicaContext`. 2. Replica initialization now requires providing a rank 3. Any change to the replicas rank will be communicated from controller via `.reconfigure()` method. 4. Assigned rank to replica can be fetched from `get_metadata()` function, this will be useful during controller recovery to reconstruct the state. This PR fills in a dummy rank value, in the future PR we will fetch the replica from DeploymentRankManager and pass in the correct value. Part 2 of ray-project#54938 Next diff in pipeline ray-project#55829 --------- Signed-off-by: abrar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rankandworld_sizeare now available onReplicaContext..reconfigure()method.get_metadata()function, this will be useful during controller recovery to reconstruct the state.This PR fills in a dummy rank value, in the future PR we will fetch the replica from DeploymentRankManager and pass in the correct value.
Part 2 of #54938
Next diff in pipeline #55829