[ci] raydepsets check lock files #55856
Conversation
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
elliot-barn
changed the title
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
ci/raydepsets/cli.py
Outdated
| + "".join(diffs) | ||
| ) | ||
| click.echo("Lock files are up to date.") | ||
| self.cleanup_temp_dir() |
There was a problem hiding this comment.
this should be called by the caller rather than here.
the entity that creates the temp dir should be the one deleting the temp dir.
ci/raydepsets/cli.py
Outdated
| target_fp, | ||
| ) | ||
|
|
||
| def diff_lock_files(self): |
There was a problem hiding this comment.
could you check if it is in check mode maybe?
There was a problem hiding this comment.
Theres a check before its called
.buildkite/dependencies.rayci.yml
Outdated
| tags: always | ||
| instance_type: small | ||
| command: ./ci/test_compile_llm_requirements.sh | ||
| command: bazel run //ci/raydepsets:raydepsets -- build ci/raydepsets/rayllm.depsets.yaml --check |
There was a problem hiding this comment.
generated lock files used to be saved in artifacts of the job, so that people can just download it and overwrite locally. are they still being saved as artifacts now?
There was a problem hiding this comment.
added some commands to copy the lock files to the artifact mount
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
ci/raydepsets/cli.py
Outdated
|
|
||
| def diff_lock_files(self): | ||
| diffs = self.get_diffs() | ||
| self.cleanup() |
There was a problem hiding this comment.
again, you would want to run cleanup by the caller, the one who constructs the DependencySetManager :)
the one creates it needs to the one who destroys it.
|
not sure why the dashboard test is triggered by this PR.. |
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
|
test seems failing? |
yes it is let me fix that quickly |
Signed-off-by: elliot-barn <[email protected]>
…:ray-project/ray into elliot-barn/raydepsets-verify-lock-files
Fixed. I won't use the Waiting on this PR to get merged before i can use |
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
Including lock file checking as part of raydepsets --------- Signed-off-by: elliot-barn <[email protected]> Co-authored-by: Lonnie Liu <[email protected]> Signed-off-by: zac <[email protected]>
Including lock file checking as part of raydepsets --------- Signed-off-by: elliot-barn <[email protected]> Co-authored-by: Lonnie Liu <[email protected]> Signed-off-by: Douglas Strodtman <[email protected]>
Including lock file checking as part of raydepsets --------- Signed-off-by: elliot-barn <[email protected]> Co-authored-by: Lonnie Liu <[email protected]>
Including lock file checking as part of raydepsets