-
Notifications
You must be signed in to change notification settings - Fork 45
fix: resize is invalid in textarea #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
概览在 TextArea 组件的 ResizableTextArea 中调整了 变更
代码审查工作量估计🎯 1 (平凡) | ⏱️ ~3 分钟
诗
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @meet-student, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a bug in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a bug concerning the resize style property on the TextArea component. The change modifies the order of properties in the style object passed to ResizableTextArea. Previously, style.resize would override styles.textarea.resize. This was problematic when style.resize was undefined (e.g., when the style prop wasn't provided), as it would nullify the resize value from styles.textarea. The new implementation correctly gives precedence to styles.textarea.resize by placing it after style.resize in the object spread. This ensures that the more specific style configuration is respected and fixes the bug. The change is correct and well-implemented.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #76 +/- ##
=======================================
Coverage 99.00% 99.00%
=======================================
Files 3 3
Lines 201 201
Branches 63 63
=======================================
Hits 199 199
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
resize 顺序问题导致 styles.textarea 写样式失效了
Summary by CodeRabbit
发布说明