docs: update lastName state updater to use toUpperCase() instead of reverse() #1293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wo-o29
requested review from
hg-pyun,
gnujoow,
eomttt and
lumirlumir
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lastName에 사용되는 메서드 사용 변경
일반적으로
lastName은 문자열로 사용되는데 배열 메서드인reverse()을 사용하여 혼란을 줄 수 있을 것 같다고 생각합니다.위와 같은 이유로 문자열 메서드인
toUpperCase()를 사용하는 것으로 변경하였습니다.필수 확인 사항
textlint가이드선택 확인 사항