[3.0] Strip FQDN period from the end of the domain #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyriHaximus
force-pushed
the
3.x-strip-fqdn-period-suffix
branch
5 times, most recently
from
7da7faa to
debe592
Compare
WyriHaximus
force-pushed
the
3.x-strip-fqdn-period-suffix
branch
from
debe592 to
1d2007f
Compare
As brought up in reactphp#229 we're already treating all domains as absolute, so adding direct support for it is a small bug fix. That said, fully support for search domains requires a different handling of this and will be done in a different PR.
WyriHaximus
force-pushed
the
3.x-strip-fqdn-period-suffix
branch
from
1d2007f to
564bdaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As brought up in #229 we're already treating all domains as absolute, so adding direct support for it is a small bug fix. That said, fully support for search domains requires a different handling of this and will be done in a different PR.