Skip to content

Enable deprecations in SubtitleHelper #2036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2025
Merged

Enable deprecations in SubtitleHelper #2036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
457ba65
Enable deprecations in SubtitleHelper
Luna712 Oct 19, 2025
8047ef6
Apply suggestions from code review
Luna712 Oct 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/main/java/com/lagradost/cloudstream3/syncproviders/providers/SubSource.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class SubSourceApi : SubtitleAPI() {

//Only supports Imdb Id search for now
if (query.imdbId == null) return null
val queryLang = SubtitleHelper.fromTwoLettersToLanguage(query.lang!!)
val queryLang = SubtitleHelper.fromTagToEnglishLanguageName(query.lang)
val type = if ((query.seasonNumber ?: 0) > 0) TvType.TvSeries else TvType.Movie

val searchRes = app.post(
Expand Down
33 changes: 20 additions & 13 deletions library/src/commonMain/kotlin/com/lagradost/cloudstream3/utils/SubtitleHelper.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,11 @@ object SubtitleHelper {
return langMetadata
}

// @Deprecated(
// "Default language code changed to IETF BCP 47 tag",
// replaceWith = ReplaceWith("fromLanguageToTagIETF(input, looseCheck)"))
@Deprecated(
"Default language code changed to IETF BCP 47 tag",
replaceWith = ReplaceWith("fromLanguageToTagIETF(input, looseCheck)"),
level = DeprecationLevel.WARNING
)
/**
* Language name (english or native) -> ISO_639_1
* @param input language name
Expand All @@ -115,10 +117,11 @@ object SubtitleHelper {
return getLanguageDataFromName(input, looseCheck)?.ISO_639_1
}


// @Deprecated(
// "Default language code changed to IETF BCP 47 tag",
// replaceWith = ReplaceWith("fromLanguageToTagIETF(input)"))
@Deprecated(
"Default language code changed to IETF BCP 47 tag",
replaceWith = ReplaceWith("fromLanguageToTagIETF(input)"),
level = DeprecationLevel.WARNING
)
/**
* Language name (english or native) -> ISO_639_3
*/
Expand Down Expand Up @@ -154,19 +157,23 @@ object SubtitleHelper {
return languages.getOrNull(index)
}

// @Deprecated(
// "Default language code changed to IETF BCP 47 tag",
// replaceWith = ReplaceWith("fromTagToLanguageName(input)"))
@Deprecated(
"Default language code changed to IETF BCP 47 tag",
replaceWith = ReplaceWith("fromTagToEnglishLanguageName(input)"),
level = DeprecationLevel.WARNING
)
/**
* Language code -> language english name
*/
fun fromTwoLettersToLanguage(input: String): String? {
return getLanguageDataFromCode(input)?.languageName
}

// @Deprecated(
// "Default language code changed to IETF BCP 47 tag",
// replaceWith = ReplaceWith("fromTagToLanguageName(input)"))
@Deprecated(
"Default language code changed to IETF BCP 47 tag",
replaceWith = ReplaceWith("fromTagToEnglishLanguageName(input)"),
level = DeprecationLevel.WARNING
)
/**
* Language code -> language english name
*/
Expand Down