Download rework #2037
Draft
Download rework #2037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| updateNotification(context, currentVisualDownloads, currentVisualQueue) | ||
|
|
||
| // Arbitrary delay to prevent hogging the CPU, decrease to make the queue feel slightly more responsive | ||
| delay(500) |
There was a problem hiding this comment.
This should be a condition variable. Unfortunately the built in synchronization primatives are built for Java threading, and not the kotlin coroutines.
The fix for this would be something like:
val conditionSignal = CompletableDeferred<Unit>()
// ...
select {
onTimeout(500) {
println("Waited")
}
conditionSignal.onAwait {
println("Skipped waiting")
}
}Select simply awaits the fastest execution. So you can conditionSignal.complete(Unit) to skip the 500ms delay. If you implement this correctly you can do a timeout of 10s or something similar.
| startForeground(DOWNLOAD_QUEUE_NOTIFICATION_ID, baseNotification.build()) | ||
| } | ||
|
|
||
| val context = this.applicationContext |
There was a problem hiding this comment.
this is a context, I do not understand why it needs to be applicationContext
| .data(url) | ||
| .apply { | ||
| headers?.forEach { (key, value) -> | ||
| extras[Extras.Key<String>(key)] = value |
There was a problem hiding this comment.
headerBuilder["User-Agent"] = USER_AGENT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the whole download system to:
Remaining issues to fix:
I plan to complete this pull request this week.