Skip to content

Conversation

AaruniAggarwal
Copy link

For building runtime-minimal konflux images on ppc64le, these changes are required. These changes are already merged in opendatahub-io/notebooks repository and have also passed konflux related checks:
for python3.12: opendatahub-io#1632
for python3.11: opendatahub-io#1175

Have also raised similar PR in this repository against rhoai-2.23-multi-arch-poc branch:
#1330

@npanpaliya
Copy link

/build-konflux

@npanpaliya npanpaliya changed the base branch from main to rhoai-2.24 August 13, 2025 06:44
@mkumatag mkumatag closed this Aug 13, 2025
@mkumatag mkumatag reopened this Aug 13, 2025
@AaruniAggarwal
Copy link
Author

/build-konflux

@AaruniAggarwal
Copy link
Author

@atheo89 , @jiridanek Could you please take a look at this PR?
Similar changes are already merged in opendatahub-io/notebooks repository.

Thanks.

@atheo89 atheo89 changed the title updating runtime-minimal konflux image for ppc64le [RHOAI-2.24] updating runtime-minimal konflux image for ppc64le Aug 14, 2025
@openshift-ci openshift-ci bot added the lgtm label Aug 14, 2025
@atheo89 atheo89 removed the lgtm label Aug 14, 2025
@atheo89
Copy link
Member

atheo89 commented Aug 14, 2025

Is there any particular reason to backport these changes only on rhoai-2.24? If not could you please add these changes on main branch? https://github.com/red-hat-data-services/notebooks/blob/main/runtimes/minimal/ubi9-python-3.12/Dockerfile.konflux.cpu

The main syncs to the release branch. Thanks

@AaruniAggarwal
Copy link
Author

Hi @atheo89, we initially raised the PR against main branch only, but there we found out that konflux build pipeline is not yet created. Hence, we changed the branch from main to rhoai-2.24 as konflux build pipeline exists there.

@AaruniAggarwal AaruniAggarwal changed the base branch from rhoai-2.24 to main August 14, 2025 15:31
@AaruniAggarwal AaruniAggarwal changed the title [RHOAI-2.24] updating runtime-minimal konflux image for ppc64le updating runtime-minimal konflux image for ppc64le Aug 14, 2025
Copy link

Caution

There are some errors in your PipelineRun template.

PipelineRun Error
odh-pipeline-runtime-minimal-cpu-py312-on-pull-request CEL expression evaluation error: failed to parse expression "": ERROR: <input>:1:0: Syntax error: mismatched input '<EOF>' expecting {'[', '{', '(', '.', '-', '!', 'true', 'false', 'null', NUM_FLOAT, NUM_INT, NUM_UINT, STRING, BYTES, IDENTIFIER}

@atheo89
Copy link
Member

atheo89 commented Aug 14, 2025

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Aug 14, 2025
Copy link

openshift-ci bot commented Aug 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Aug 14, 2025

@AaruniAggarwal: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 180fb8e link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mkumatag mkumatag changed the base branch from main to rhoai-2.24 August 15, 2025 12:07
@mkumatag
Copy link

/build-konflux

@wznoinsk
Copy link

merged as part of #1484

@mkumatag
Copy link

thanks @wznoinsk

@mkumatag mkumatag closed this Aug 16, 2025
@mkumatag mkumatag deleted the konflux-ppc branch August 16, 2025 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants