Skip to content

controllers: fix useHostNetworkForCsiControllersKey parsing from CM #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rohan47 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

controllers: fix useHostNetworkForCsiControllersKey parsing from CM #482

rohan47 wants to merge 1 commit into from

Conversation

@rohan47
Copy link
Contributor

@rohan47 rohan47 commented Oct 13, 2025

csi controller plugin host network was getting set to false if the useHostNetworkForCsiControllersKey was not present, changed it to apply the correct value only if the key is present

@openshift-ci
Copy link

openshift-ci bot commented Oct 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rohan47
Once this PR has been reviewed and has the lgtm label, please assign madhu-1 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rohan47
Copy link
Contributor Author

rohan47 commented Oct 13, 2025

by default the controller plugin will use hostNetwork https://github.com/red-hat-storage/ocs-client-operator/blob/main/pkg/templates/csi.go#L191

@rohan47
controllers: fix useHostNetworkForCsiControllersKey parsing from CM
188f6e2 
csi controller plugin host network was getting set to false if the
useHostNetworkForCsiControllersKey was not present, changed it to apply
the correct value only if the key is present

Signed-off-by: Rohan Gupta <[email protected]>
@rohan47 rohan47 marked this pull request as draft October 14, 2025 09:56
@rohan47 rohan47 marked this pull request as ready for review October 14, 2025 15:51
@openshift-merge-robot
Copy link

openshift-merge-robot commented Nov 30, 2025

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs-rebase size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rohan47 @openshift-merge-robot