Bugfix/#21003 update hosts file #70
Open
+171
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 2.3.0
Release 2.3.1
This reverts commit 8b146a4. service_name not known in this chef version
Release 2.3.2
Release 2.3.3
…redirect with nginx.
Release 2.4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://redmine.redborder.lan/issues/21226
The goal of this task was initially to just fix the resolution in /etc/hosts to services in the manager, and also keep the connection with services in localhost.
Old process:
It is expected that anything chages the /etc/hosts file
Chef runs, calling update_file_hosts
Update_file_hosts reads /etc/hosts file
Update_file_hosts checks diffs between /etc/hosts file and nodes information.
Update_file_hosts only updates the new information on hosts.erb
Chef passes hosts mapped information to a simple template hosts.erb
The management of hosts.erb was getting complicated because of a concurrent condition and diff checks. It feels that this process is breaking the first two rules of SOLID. The process now is:
We don't care if some deprecated process add new lines in /etc/hosts, it should be in nodes information.
Chef runs, calling update_file_hosts
Update_file_hosts gathers information from nodes
Chef passes hosts mapped information to hosts.erb
In hosts.erb file we can define the order of the hosts information, aswell the new hosts we want to add on demand during next iteration.
Now update_file_hosts only writes the information in the node, but also leaves open for modifications the hosts.erb