Skip to content

Conversation

filariow
Copy link
Member

@filariow filariow commented Jul 28, 2025

Applying Kyverno's Best Practices on integration with ArgoCD to all cluster.

This PR reverts #8032

Requires:

Signed-off-by: Francesco Ilario [email protected]

Copy link
Contributor

@hugares hugares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hugares
Copy link
Contributor

hugares commented Aug 11, 2025

/hold to allow you to merge when you want

@filariow filariow force-pushed the kyverno-policies-argocd-diff branch from c40a79d to 828673a Compare September 9, 2025 15:42
@openshift-ci openshift-ci bot removed the lgtm label Sep 9, 2025
@filariow filariow requested a review from hugares September 9, 2025 15:43
Copy link
Contributor

github-actions bot commented Sep 9, 2025

Code Review by Gemini

The changes align with Kyverno's Best Practices for integration with ArgoCD by moving the ServerSideDiff and IncludeMutationWebhook annotations directly into the base ApplicationSet definition. This is a positive change that centralizes the configuration and simplifies the overlay structure.

No bugs or issues were found in the provided changes.

Improvements:

The current change is already an improvement by:

  1. Centralizing the argocd.argoproj.io/compare-options annotation in the base ApplicationSet definition.
  2. Removing redundant overlay patches (kyverno-argocd-diff.yaml) from development and staging-downstream environments, which simplifies the Kustomize structure and reduces duplication.

No further code changes are suggested as the current implementation correctly applies the best practice.

Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest
/hold

Merge this when you're ready.

Copy link

openshift-ci bot commented Sep 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: filariow, hugares, sadlerap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@filariow
Copy link
Member Author

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit 3e37c87 into redhat-appstudio:main Sep 15, 2025
8 checks passed
@filariow filariow deleted the kyverno-policies-argocd-diff branch September 16, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants