Skip to content

Conversation

enkeefe00
Copy link
Contributor

Add a GitHub workflow to create/update an MR for updating the MPC user doc's Available Platform Variants by Cluster table whenever changes to a cluster's MPC host config are detected in a PR.

Assisted by: Cursor & Gemini

@enkeefe00 enkeefe00 self-assigned this Oct 8, 2025
@openshift-ci openshift-ci bot requested review from jgwest and tisutisu October 8, 2025 14:20
Copy link

openshift-ci bot commented Oct 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: enkeefe00
Once this PR has been reviewed and has the lgtm label, please assign adambkaplan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

github-actions bot commented Oct 8, 2025

🤖 Gemini AI Assistant Available

Hi @enkeefe00! I'm here to help with your pull request. You can interact with me using the following commands:

Available Commands

  • @gemini-cli /review - Request a comprehensive code review

    • Example: @gemini-cli /review Please focus on security and performance
  • @gemini-cli <your question> - Ask me anything about the codebase

    • Example: @gemini-cli How can I improve this function?
    • Example: @gemini-cli What are the best practices for error handling here?

How to Use

  1. Simply type one of the commands above in a comment on this PR
  2. I'll analyze your code and provide detailed feedback
  3. You can track my progress in the workflow logs

Permissions

Only OWNER, MEMBER, or COLLABORATOR users can trigger my responses. This ensures secure and appropriate usage.


This message was automatically added to help you get started with the Gemini AI assistant. Feel free to delete this comment if you don't need assistance.

Copy link
Contributor

github-actions bot commented Oct 8, 2025

🤖 Hi @enkeefe00, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@enkeefe00
Copy link
Contributor Author

@gemini-cli /review

@enkeefe00 enkeefe00 force-pushed the mpc-docs-update-workflow branch 2 times, most recently from a49a290 to e16a6fc Compare October 10, 2025 19:01
Add a GitHub workflow to create/update an MR for updating the MPC user
doc's Available Platform Variants by Cluster table whenever changes to
a cluster's MPC host values are detected in a PR.

Assisted by: Cursor & Gemini
@enkeefe00 enkeefe00 force-pushed the mpc-docs-update-workflow branch from e16a6fc to 1750215 Compare October 10, 2025 19:48
Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts, largely looks good to me.

Comment on lines +12 to +16
on:
pull_request_target:
paths:
- 'components/multi-platform-controller/**/host-values.yaml'
types: [opened, synchronize, reopened]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think on triggering this workflow on pushes instead of on pull requests? I'm worried about the following sequence of events:

  1. we open a PR to infra-deployments
  2. this workflow opens a MR on gitlab
  3. we merge that MR
  4. we later decide that the PR is wrong and close it.

This puts our documentation on gitlab out-of-sync with what we have on github and requires manual intervention to cleanup (sure, it's as easy as git revert, but that's a manual step I'd like to remove from ever happening in the first place).

I'm fine with this PR either way, just food for thought.

Comment on lines +63 to +68

if [ -z "$CHANGED_FILES" ]; then
echo "No MPC host-values.yaml files were changed in this PR"
echo "has_host_values=false" >> $GITHUB_OUTPUT
exit 0
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we set the path on the trigger for this PR, this check is redundant.

Suggested change
if [ -z "$CHANGED_FILES" ]; then
echo "No MPC host-values.yaml files were changed in this PR"
echo "has_host_values=false" >> $GITHUB_OUTPUT
exit 0
fi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants