Skip to content

Conversation

sadlerap
Copy link
Contributor

@sadlerap sadlerap commented Oct 9, 2025

We're introducing yamllint checks to the manifests in this repository (#8461). Repository validator's manifests have formatting issues that yamllint calls out, so fix these warnings.

This is split from #8461 since repository validator's formatted manifests don't exactly line up with their pre-formatted versions.

Copy link
Contributor

github-actions bot commented Oct 9, 2025

🤖 Gemini AI Assistant Available

Hi @sadlerap! I'm here to help with your pull request. You can interact with me using the following commands:

Available Commands

  • @gemini-cli /review - Request a comprehensive code review

    • Example: @gemini-cli /review Please focus on security and performance
  • @gemini-cli <your question> - Ask me anything about the codebase

    • Example: @gemini-cli How can I improve this function?
    • Example: @gemini-cli What are the best practices for error handling here?

How to Use

  1. Simply type one of the commands above in a comment on this PR
  2. I'll analyze your code and provide detailed feedback
  3. You can track my progress in the workflow logs

Permissions

Only OWNER, MEMBER, or COLLABORATOR users can trigger my responses. This ensures secure and appropriate usage.


This message was automatically added to help you get started with the Gemini AI assistant. Feel free to delete this comment if you don't need assistance.

Copy link
Contributor

github-actions bot commented Oct 9, 2025

🤖 Hi @sadlerap, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

Copy link
Contributor

@hugares hugares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@redhat-appstudio-qe-bot
Copy link

❗ Detected an outage of the following critical component(s)❗

  • github: Webhooks

Due to this issue E2E tests will probably fail. Please keep an eye on the following status pages:

and add a comment /retest-required once the reported issues are solved

2 similar comments
@redhat-appstudio-qe-bot
Copy link

❗ Detected an outage of the following critical component(s)❗

  • github: Webhooks

Due to this issue E2E tests will probably fail. Please keep an eye on the following status pages:

and add a comment /retest-required once the reported issues are solved

@redhat-appstudio-qe-bot
Copy link

❗ Detected an outage of the following critical component(s)❗

  • github: Webhooks

Due to this issue E2E tests will probably fail. Please keep an eye on the following status pages:

and add a comment /retest-required once the reported issues are solved

@sadlerap
Copy link
Contributor Author

sadlerap commented Oct 9, 2025

/retest

@hugares
Copy link
Contributor

hugares commented Oct 10, 2025

@sadlerap you need to rebase this one, it has conflicts

We're introducing yamllint checks to the manifests in this repository
(redhat-appstudio#8461).  Repository validator's manifests have formatting issues that
yamllint calls out, so fix these warnings.

This is split from redhat-appstudio#8461 since repository validator's formatted
manifests don't exactly line up with their pre-formatted versions.

Part-of: KFLUXINFRA-2285
Signed-off-by: Andy Sadler <[email protected]>
@sadlerap sadlerap force-pushed the repository-validator-fix-manifests branch from feb218f to e84c53a Compare October 10, 2025 16:58
@openshift-ci openshift-ci bot removed the lgtm label Oct 10, 2025
Copy link
Contributor

@hugares hugares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 10, 2025
Copy link

openshift-ci bot commented Oct 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hugares, sadlerap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Oct 10, 2025

@sadlerap: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/konflux-e2e-v418-optional e84c53a link false /test konflux-e2e-v418-optional

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sadlerap
Copy link
Contributor Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 9ed88ed into redhat-appstudio:main Oct 10, 2025
9 of 10 checks passed
@sadlerap sadlerap deleted the repository-validator-fix-manifests branch October 10, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants