Skip to content

Conversation

@maruiz93
Copy link
Contributor

The KubeArchive CLI has recently introduced a feature that allows automatic configuration by trying to discover, among other things, an Openshift Route to access the KubeArchive API.

For this to work, the users should have access to the Routes in the product-kubearchive namespace.

This PR provides RBAC permissions to every authenticated user in the cluster.

@openshift-ci
Copy link

openshift-ci bot commented Dec 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maruiz93

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link
Contributor

🤖 Gemini AI Assistant Available

Hi @maruiz93! I'm here to help with your pull request. You can interact with me using the following commands:

Available Commands

  • @gemini-cli /review - Request a comprehensive code review

    • Example: @gemini-cli /review Please focus on security and performance
  • @gemini-cli <your question> - Ask me anything about the codebase

    • Example: @gemini-cli How can I improve this function?
    • Example: @gemini-cli What are the best practices for error handling here?

How to Use

  1. Simply type one of the commands above in a comment on this PR
  2. I'll analyze your code and provide detailed feedback
  3. You can track my progress in the workflow logs

Permissions

Only OWNER, MEMBER, or COLLABORATOR users can trigger my responses. This ensures secure and appropriate usage.


This message was automatically added to help you get started with the Gemini AI assistant. Feel free to delete this comment if you don't need assistance.

@github-actions
Copy link
Contributor

🤖 Hi @maruiz93, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

kind: RoleBinding
apiVersion: rbac.authorization.k8s.io/v1
metadata:
name: authenticated-route-access
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would call it kubearchive-route-reader to match the role.

Copy link
Member

@gbenhaim gbenhaim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Routes can contain sensitive information such as TLS key. I understand that this isn't the case for Kubearchive today, but I general I don't think we should allow any route configuration to be visible to any authenticated user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants