-
Notifications
You must be signed in to change notification settings - Fork 315
chore(KFLUXUI-943): deploy kite to stone-stage-p01 #9620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(KFLUXUI-943): deploy kite to stone-stage-p01 #9620
Conversation
🤖 Gemini AI Assistant AvailableHi @JoaoPedroPP! I'm here to help with your pull request. You can interact with me using the following commands: Available Commands
How to Use
PermissionsOnly OWNER, MEMBER, or COLLABORATOR users can trigger my responses. This ensures secure and appropriate usage. This message was automatically added to help you get started with the Gemini AI assistant. Feel free to delete this comment if you don't need assistance. |
|
🤖 Hi @JoaoPedroPP, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
| @@ -0,0 +1,33 @@ | |||
| apiVersion: kustomize.config.k8s.io/v1beta1 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kite application is not deployed in staging-downtream overlay, you need to remove the patch deleting the application but also change the applicatset to generate application with right path. Here is the diff of what is missing:
git diff
diff --git a/argo-cd-apps/base/member/infra-deployments/konflux-kite/konflux-kite.yaml b/argo-cd-apps/base/member/infra-deployments/konflux-kite/konflux-kite.yaml
index d53caf967..63a1e29f0 100644
--- a/argo-cd-apps/base/member/infra-deployments/konflux-kite/konflux-kite.yaml
+++ b/argo-cd-apps/base/member/infra-deployments/konflux-kite/konflux-kite.yaml
@@ -19,6 +19,8 @@ spec:
# Staging clusters
- nameNormalized: stone-stg-rh01
values.clusterDir: stone-stg-rh01
+ - nameNormalized: stone-stage-p01
+ values.clusterDir: stone-stage-p01
template:
metadata:
name: konflux-kite-{{nameNormalized}}
diff --git a/argo-cd-apps/overlays/staging-downstream/delete-applications.yaml b/argo-cd-apps/overlays/staging-downstream/delete-applications.yaml
index 95c9b33ab..44583d45e 100644
--- a/argo-cd-apps/overlays/staging-downstream/delete-applications.yaml
+++ b/argo-cd-apps/overlays/staging-downstream/delete-applications.yaml
@@ -10,10 +10,3 @@ kind: ApplicationSet
metadata:
name: quality-dashboard
$patch: delete
----
-# At this time we're starting with external staging
-apiVersion: argoproj.io/v1alpha1
-kind: ApplicationSet
-metadata:
- name: konflux-kite
-$patch: delete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in new version.
Out of curiosity, why did we need to delete konflux-kite ApplicationSet if we only had deploy set?
1b17056 to
2e5319c
Compare
Deploy kite to stone-stage-p01 cluster (Private konflux instance) KFLUXUI-943
2e5319c to
d9fdc85
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JoaoPedroPP The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Deploy kite to stone-stage-p01 cluster (Private konflux instance)
KFLUXUI-943