Skip to content

Conversation

@hugares
Copy link
Contributor

@hugares hugares commented Dec 12, 2025

RHEL needs to extract secrets from same vault in more than one namespace. Create a cluster level store for them since user can only create namespace stores. This is similar to what we did for Insights.

Since this store is on internal cluster, configure to extract directly from internal vault. To do so, inject the trusted-ca into the appsre-vault namespace and get the approle secret from our own vault.

KFLUXINFRA-2706

@github-actions
Copy link
Contributor

🤖 Gemini AI Assistant Available

Hi @hugares! I'm here to help with your pull request. You can interact with me using the following commands:

Available Commands

  • @gemini-cli /review - Request a comprehensive code review

    • Example: @gemini-cli /review Please focus on security and performance
  • @gemini-cli <your question> - Ask me anything about the codebase

    • Example: @gemini-cli How can I improve this function?
    • Example: @gemini-cli What are the best practices for error handling here?

How to Use

  1. Simply type one of the commands above in a comment on this PR
  2. I'll analyze your code and provide detailed feedback
  3. You can track my progress in the workflow logs

Permissions

Only OWNER, MEMBER, or COLLABORATOR users can trigger my responses. This ensures secure and appropriate usage.


This message was automatically added to help you get started with the Gemini AI assistant. Feel free to delete this comment if you don't need assistance.

@github-actions
Copy link
Contributor

🤖 Hi @hugares, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

Copy link
Contributor

@mshaposhnik mshaposhnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Comment on lines 11 to 12
data: {}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably get rid of this field, argo might get upset when the data field gets populated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

metadata:
name: rhel-appsre-vault-approle
annotations:
argocd.argoproj.io/sync-options: SkipDryRunOnMissingResource=true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this seems to be a common annotation to all resources, should this get applied as an annotation in the kustomization.yaml manifest?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@sadlerap
Copy link
Contributor

/hold

unhold when ready to merge

RHEL needs to extract secrets from same vault in more than one
namespace. Create a cluster level store for them since user can only
create namespace stores. This is similar to what we did for Insights.

Since this store is on internal cluster, configure to extract directly
from internal vault. To do so, inject the trusted-ca into the
appsre-vault namespace and get the approle secret from our own vault.

KFLUXINFRA-2706

Signed-off-by: Hugo Ares <[email protected]>
Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Dec 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enkeefe00, hugares, jpopelka, mshaposhnik, sadlerap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants