-
Notifications
You must be signed in to change notification settings - Fork 315
Create a ClusterSecretStore for RHEL #9636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🤖 Gemini AI Assistant AvailableHi @hugares! I'm here to help with your pull request. You can interact with me using the following commands: Available Commands
How to Use
PermissionsOnly OWNER, MEMBER, or COLLABORATOR users can trigger my responses. This ensures secure and appropriate usage. This message was automatically added to help you get started with the Gemini AI assistant. Feel free to delete this comment if you don't need assistance. |
|
🤖 Hi @hugares, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
mshaposhnik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
| data: {} | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably get rid of this field, argo might get upset when the data field gets populated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| metadata: | ||
| name: rhel-appsre-vault-approle | ||
| annotations: | ||
| argocd.argoproj.io/sync-options: SkipDryRunOnMissingResource=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this seems to be a common annotation to all resources, should this get applied as an annotation in the kustomization.yaml manifest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
/hold unhold when ready to merge |
RHEL needs to extract secrets from same vault in more than one namespace. Create a cluster level store for them since user can only create namespace stores. This is similar to what we did for Insights. Since this store is on internal cluster, configure to extract directly from internal vault. To do so, inject the trusted-ca into the appsre-vault namespace and get the approle secret from our own vault. KFLUXINFRA-2706 Signed-off-by: Hugo Ares <[email protected]>
b728eaf to
6da085b
Compare
sadlerap
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enkeefe00, hugares, jpopelka, mshaposhnik, sadlerap The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
RHEL needs to extract secrets from same vault in more than one namespace. Create a cluster level store for them since user can only create namespace stores. This is similar to what we did for Insights.
Since this store is on internal cluster, configure to extract directly from internal vault. To do so, inject the trusted-ca into the appsre-vault namespace and get the approle secret from our own vault.
KFLUXINFRA-2706