Skip to content

fix(PVO11Y-4961): Change group by to include source cluster #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martysp21 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(PVO11Y-4961): Change group by to include source cluster #866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rhobs/recording/konflux_ui_availability_recording_rules.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ spec:
), 1
)
- record: nginx_otel_http_request_errors:rate5m
expr: sum(rate(nginx_otel_http_request_errors_total[5m])) by (job, status)
expr: sum(rate(nginx_otel_http_request_errors_total[5m])) by (job, status, source_cluster)
Copy link
Collaborator

@pacho-rh pacho-rh Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made this change as part of https://github.com/redhat-appstudio/o11y/pull/867/files#diff-2229f18913c457accaf8f559473a677a70d2cba7fb36311613eb78c0a63e5602R39

It did not include the added recording rules testing you have here though.


- record: nginx_otel_http_request_errors:rate24h_avg
expr: avg_over_time(nginx_otel_http_request_errors:rate5m[24h])
Expand Down
39 changes: 39 additions & 0 deletions test/promql/tests/recording/konflux_ui_availability_recording_rules_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,42 @@ tests:
exp_samples:
- labels: konflux_up{service='dex', check='replicas-available', namespace='konflux-ui', deployment='dex'}
value: 0

- name: NginxOtelHttpRequestErrorsRate5mTest
interval: 1m
input_series:
- series: 'nginx_otel_http_request_errors_total{job="nginx-proxy", status="500", source_cluster="c1"}'
values: '0 2 4 6 8'
- series: 'nginx_otel_http_request_errors_total{job="nginx-proxy", status="404", source_cluster="c1"}'
values: '0 1 1 2 2'
promql_expr_test:
- expr: nginx_otel_http_request_errors:rate5m
eval_time: 5m
exp_samples:
- labels: nginx_otel_http_request_errors:rate5m{job="nginx-proxy", status="500", source_cluster="c1"}
value: 1.6
- labels: nginx_otel_http_request_errors:rate5m{job="nginx-proxy", status="404", source_cluster="c1"}
value: 0.4

- name: NginxOtelHttpRequestErrorsRate24hAvgTest
interval: 1m
input_series:
- series: 'nginx_otel_http_request_errors:rate5m{job="nginx-proxy", status="500", source_cluster="c2"}'
values: '0.5 1.0 1.5 2.0 2.5 3.0 3.5 4.0 4.5 5.0 5.5 6.0 6.5 7.0 7.5'
promql_expr_test:
- expr: nginx_otel_http_request_errors:rate24h_avg
eval_time: 15m
exp_samples:
- labels: nginx_otel_http_request_errors:rate24h_avg{job="nginx-proxy", status="500", source_cluster="c2"}
value: 4.0
- name: NginxOtelHttpRequestErrorsRate24hStddevTest
interval: 1m
input_series:
- series: 'nginx_otel_http_request_errors:rate5m{job="nginx-proxy", status="500", source_cluster="c3"}'
values: '1 2 3 4 5 6 7 8 9 10 11 12 13 14 15'
promql_expr_test:
- expr: nginx_otel_http_request_errors:rate24h_stddev
eval_time: 15m
exp_samples:
- labels: nginx_otel_http_request_errors:rate24h_stddev{job="nginx-proxy", status="500", source_cluster="c3"}
value: 4.0