Skip to content

Conversation

cidrbl0ck
Copy link
Contributor

Re-wording on line 9

What does this PR do?

I just re-wored the end of line 9 a bit to be more accurate based on what's presented below line 9. It lists 4 roles instead of 3. And comprised of reads better than compose by.

How should this be tested?

Is there a relevant Issue open for this?

resolves #[number]

Other Relevant info, PRs, etc

Re-wording on line 9
Copy link
Contributor

@djdanielsson djdanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been looking at this... I think this needs a bit of a re-write because the roles are no longer inside the aap_configuration collection and that needs to be explained some because dispatch is apart of that collection not this collection.

@cidrbl0ck
Copy link
Contributor Author

Ah sounds like a deeper rewrite than what I looked at.

@sean-m-sullivan sean-m-sullivan self-requested a review April 3, 2025 13:40
Copy link
Contributor

@djdanielsson djdanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs a bigger rewrite

@cidrbl0ck
Copy link
Contributor Author

FWIW I'd be willing to give it a shot, but TBH I don't quite know dispatchers role in things.

@djdanielsson
Copy link
Contributor

the dispatchers role is calling all the other roles to apply the configuration in the correct order

@sean-m-sullivan sean-m-sullivan self-requested a review August 29, 2025 17:19
@djdanielsson djdanielsson merged commit 4425f5c into redhat-cop:devel Aug 29, 2025
9 checks passed
piergiovannimanfrin pushed a commit to piergiovannimanfrin/aap_configuration_extended that referenced this pull request Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants