feat: Add csi-driver-nfs #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarguello
requested review from
gnunn1,
pittar and
strangiato
as code owners
rarguello
force-pushed
the
csi-driver-nfs
branch
from
04d63d7 to
ade8426
Compare
pittar
reviewed
Nov 5, 2025
Collaborator
pittar
left a comment
pittar
left a comment
There was a problem hiding this comment.
@rarguello , thanks for the contribution.
This looks good, just curious about the version that you've chosen to include (4.11.0). I don't know enough about this driver to know if that's the right version or not. Can you explain why not the latest?
pittar
approved these changes
Nov 6, 2025
Collaborator
pittar
left a comment
pittar
left a comment
There was a problem hiding this comment.
LGTM. Will look at updating to 4.12.x version of the driver post merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for https://github.com/kubernetes-csi/csi-driver-nfs