-
Notifications
You must be signed in to change notification settings - Fork 210
feat(marketplace): convert support field to object structure with name and level properties #3329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(marketplace): convert support field to object structure with name and level properties #3329
Conversation
Signed-off-by: its-mitesh-kumar <[email protected]>
|
/retest-required |
1 similar comment
|
/retest-required |
| publisher: Red Hat | ||
| support: tech-preview | ||
| support: | ||
| name: Parfümerie Douglas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the repo for the plugin is in the backstage community plugins, I think we should set this to "Backstage Community"
| url: https://roadie.io/ | ||
| support: tech-preview | ||
| support: | ||
| name: Roadie |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the repo for the plugin is in the backstage community plugins, I think we should set this to "Backstage Community"
| author: Dynatrace | ||
| support: production | ||
| support: | ||
| name: Dynatrace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing support.name from Dynatrace to Backstage Community.
FYI @benwilcock @christoph-jerolimov
| url: https://roadie.io/ | ||
| support: production | ||
| support: | ||
| name: Roadie |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing support.name from Roadie to Backstage Community.
FYI @benwilcock @christoph-jerolimov
| publisher: Red Hat | ||
| support: tech-preview # production, tech-preview, dev-preveiw | ||
| support: | ||
| name: ImmobiliareLabs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing support.name to Backstage Community here.
FYI @benwilcock @christoph-jerolimov
Signed-off-by: its-mitesh-kumar <[email protected]>
|
|
The image is available at: |
Signed-off-by: its-mitesh-kumar <[email protected]>
|
The image is available at: |
|
/retest |
christoph-jerolimov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay with the review.
I believe we
- should not use the provider "Backstage Community" when the level is "tech-preview". It's us or someone else, but currently its always on us.
- when the support level is community we could maybe also say "Backstage Community" and not us. This is just the case for servicenow. Since it is developed by us its also okay to say Red Hat. I will ping @benwilcock on slack for this.
| author: Backstage Community | ||
| support: tech-preview | ||
| support: | ||
| provider: Backstage Community |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think when its Tech Preview we should say support is from Red Hat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christoph-jerolimov, I am waiting for final decision of this discussion for updating it.
| author: Backstage Community | ||
| support: tech-preview | ||
| support: | ||
| provider: Backstage Community |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, for tech preview support it should be Red Hat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christoph-jerolimov, I am waiting for final decision of this discussion for updating it.
| publisher: Red Hat | ||
| lifecycle: active | ||
| support: tech-preview | ||
| # support: tech-preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove this old line
| # support: tech-preview |
| support: tech-preview | ||
| support: | ||
| provider: Red Hat | ||
| level: generally-available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
| publisher: Red Hat | ||
| support: tech-preview | ||
| support: | ||
| provider: Backstage Community |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for tech-preview it should be Red Hat
| publisher: Red Hat | ||
| support: tech-preview | ||
| support: | ||
| provider: Backstage Community |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for tech-preview it should be Red Hat
| publisher: Red Hat | ||
| support: tech-preview | ||
| support: | ||
| provider: Backstage Community |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when its tech-review it should be Red Hat
| spec: | ||
| support: dev-preview | ||
| support: | ||
| provider: Red Hat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| provider: Red Hat | |
| provider: Backstage Community |
When its not DP, TP @benwilcock , we don't say we support it, or?
|
Fyi, we can't merge this PR yet because the extensions catalog will show no plugins with just this updated entities. We also need to update the extensions/marketplace wrapper. (This must not be handled in this PR. But this must be merged before. For this we need to release it first on rhdh-plugins...) /hold |
|
The image is available at: |
|
Marketplace PR #3479 was merged, this should finally unhold this PR as well. Please rebase this PR so that we can test both together. Thanks a lot @its-mitesh-kumar /unhold |
Signed-off-by: its-mitesh-kumar <[email protected]>
Signed-off-by: its-mitesh-kumar <[email protected]>
| lifecycle: active | ||
| support: tech-preview | ||
| support: | ||
| provider: Red Hat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
provider is RH but the authors are Backstage Community? so we SUPPORT it but don't OWN it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this is correct :)
We support it as tech-preview because we bundle it with a wrapper, so we're responsible.
|
The image is available at: |
|
@its-mitesh-kumar: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test e2e-ocp-helm |
christoph-jerolimov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christoph-jerolimov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
acd1a3e
into
redhat-developer:main

Description
This PR updates all 77 marketplace plugin YAML files to use the new object structure for the
supportfield, replacing the previous string format with a structured approach that includes both support provider name and support level.Plugin sheet for
Support LevelandProviderfor reference.Issue
For issue https://issues.redhat.com/browse/RHIDP-8469
Changes Made
Schema Update
ga,tech-preview,dev-previewoneOfpatternPlugin Files Updated (77 total)
All plugin files in
catalog-entities/marketplace/plugins/converted from:To:
RHDH Marketplace Plugin Classification
Classification by Support.Name
Red Hat (66 plugins)
3scaleadoption-insightsanalytics-provider-segmentansible-pluginargocd-scaffolder-actionsazure-container-registryazure-devopsazure-repositoriesbackstage-community-plugin-quaybitbucket-cloud-catalog-integrationbitbucket-cloud-scaffolder-actionsbitbucket-server-catalog-integrationbulk-importcontrib-techdocs-addonsdatadogdynatrace-communityextensionsgithub-actionsgithub-catalog-integrationgithub-insightsgithub-issuesgithub-org-catalog-integrationgithub-pull-requestsgithub-scaffolder-actionsgitlab-catalog-cardsgitlab-scaffolder-actionsglobal-floating-action-buttonglobal-headerhome-pagehttp-request-scaffolder-actionjenkinsjfrog-artifactoryjirakeycloak-catalog-integrationkuberneteskubernetes-backendkubernetes-scaffolder-actionsldap-catalog-integrationlighthouselightspeedmicrosoft-graph-catalog-integrationnexus-repository-managernotificationsnotifications-emailopenshift-cluster-manageroptimizationsorchestratororchestrator-scaffolder-actionspagerdutypingidentityquay-scaffolder-actionsquickstartrbacredhat-argocdregex-scaffolder-actionsroadie-argocdscaffolder-relation-processor-catalog-integrationservicenowservicenow-scaffolder-actionssignalssignals-backendsonarqube-catalog-cardstech-radartechdocstektontopologyBackstage Community (8 plugins)
azure-scaffolder-actionsbitbucket-server-scaffolder-actionsgerrit-scaffolder-actionsgitlab-catalog-integrationgitlab-org-catalog-integrationroadie-scaffolder-util-actionssecurity-insightssonarqube-scaffolder-actionsThird-Party Vendors (2 plugins)
ibm-apiconnect-backstagedynatrace-commercialClassification by Support.Level
GA (General Availability) (26 plugins)
adoption-insightsanalytics-provider-segmentansible-pluginbackstage-community-plugin-quaycontrib-techdocs-addonsdynatrace-commercialgithub-catalog-integrationgithub-org-catalog-integrationgithub-scaffolder-actionsglobal-floating-action-buttonglobal-headerhome-pageibm-apiconnect-backstagekeycloak-catalog-integrationkubernetes-backendkubernetes-scaffolder-actionsopenshift-cluster-managerquay-scaffolder-actionsquickstartrbacregex-scaffolder-actionsroadie-argocdsignals-backendtechdocstektontopologyTech-Preview (48 plugins)
3scaleargocd-scaffolder-actionsazure-container-registryazure-devopsazure-repositoriesazure-scaffolder-actionsbitbucket-cloud-catalog-integrationbitbucket-cloud-scaffolder-actionsbitbucket-server-catalog-integrationbitbucket-server-scaffolder-actionsbulk-importdatadogdynatrace-communityextensionsgerrit-scaffolder-actionsgithub-actionsgithub-insightsgithub-issuesgithub-pull-requestsgitlab-catalog-cardsgitlab-catalog-integrationgitlab-org-catalog-integrationgitlab-scaffolder-actionshttp-request-scaffolder-actionjenkinsjfrog-artifactoryjirakubernetesldap-catalog-integrationlighthousemicrosoft-graph-catalog-integrationnexus-repository-managernotificationsnotifications-emailoptimizationsorchestratororchestrator-scaffolder-actionspagerdutypingidentityredhat-argocdroadie-scaffolder-util-actionsscaffolder-relation-processor-catalog-integrationsecurity-insightsservicenow-scaffolder-actionssignalssonarqube-catalog-cardssonarqube-scaffolder-actionstech-radarDev-Preview (2 plugins)
lightspeedservicenowSummary Statistics
By Support Provider (support.name)
By Support Level (support.level)
Support Level Distribution by Provider
Total Marketplace Plugins: 76
Related