Changes from 500 VMs Hybrid work #733
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
docs/troubleshooting.md
Outdated
| Object value modified successfully | ||
| ``` | ||
|
|
||
| ## Failing ImagePull due to Pull Secret |
There was a problem hiding this comment.
Is this scenario for when the user can no longer update the pull-secret by oc -n openshift-config edit secret/pull-secret ?
There was a problem hiding this comment.
Yes. I only encountered it when the credentials installed in the cluster belonged to an account that was deactivated and no nodes would pull images.
I didn't like this section of the Troubleshooting doc to place it under, but wasn't sure there was any better option. Open to suggestions on that too.
ansible/roles/wait-hosts-discovered/tasks/set_hostname_role.yml
Outdated
Show resolved
Hide resolved
Adds VM recovery playbooks Enable hugepages on the hypervisor and VM configuration. Add playbook to disable devices created for virtual functions Working changes to configure hugetlb Complaint of a missing var, this import seems required Improve CSR approve and node Ready wait loop Add interfaces that can be used as virtual functions But they seemed to generate a lot of iowait activity on the VMs, so I don't know whether something is wrong with them or not Some changes were generated using Cursor and the claude-4-sonnet model. Signed-off-by: Andrew Collins <[email protected]> Apply suggestion from @mcornea Co-authored-by: Marius Cornea <[email protected]>
afcollins
force-pushed
the
hv-hugepages
branch
from
c04998a to
69b8036
Compare
Renamed variable to remove "enabled" Added new variable to switch ON VFs in VMs. Defaults to OFF.
Signed-off-by: Andrew Collins <[email protected]>
Signed-off-by: Andrew Collins <[email protected]>
Signed-off-by: Andrew Collins <[email protected]>
|
Addressed all comments. Reverted some unnecessary changes. Renamed a variable. Added a variable for VFs in VMs. Please take another look when you can. I still don't have a way to validate these changes for right now. :/ But may be able to do so in early December. |
3 participants
Adds VM recovery playbooks
Enable hugepages on the hypervisor and VM configuration. Add playbook to disable devices created for virtual functions Working changes to configure hugetlb
Complaint of a missing var, this import seems required
Improve CSR approve and node Ready wait loop
Add interfaces that can be used as virtual functions But they seemed to generate a lot of iowait activity on the VMs, so I don't know whether something is wrong with them or not
Some changes were generated using Cursor and the claude-4-sonnet model.