-
Notifications
You must be signed in to change notification settings - Fork 2
Initial support of PCP metrics gathering capability #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds "--use_pcp" option in general_setup Adds PCP infrastrucure including systemd service, default configs for pmlogger and openmetrics, commands and functions for use by wrappers, and sundries
This relates to RPOPC-517 |
dvalinrh
reviewed
Jul 8, 2025
dvalinrh
reviewed
Jul 14, 2025
dvalinrh
reviewed
Jul 14, 2025
dvalinrh
reviewed
Jul 14, 2025
dvalinrh
reviewed
Jul 14, 2025
dvalinrh
reviewed
Jul 14, 2025
dvalinrh
reviewed
Jul 14, 2025
dvalinrh
reviewed
Jul 14, 2025
dvalinrh
requested changes
Jul 14, 2025
dvalinrh
reviewed
Aug 4, 2025
dvalinrh
reviewed
Aug 4, 2025
dvalinrh
requested changes
Aug 4, 2025
dvalinrh
approved these changes
Aug 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good enough to soak.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
group_review_lgtm
Indicates approval after a group review meeting
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This add initial PCP support to the common toolset for the "Zathras family" of workload wrappers as part of the migration from pbench
Before/After Comparison
Before: no Zathras-wide support for PCP
After: We have initial support for the use of PCP among the "Zathras family of wrapper"
Clerical Stuff
This closes #71
Relates to JIRA: RPOPC-517