One scp command isn't turning off strict host key checking #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvalinrh
approved these changes
Sep 2, 2025
kdvalin
added
the
group_review_lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where the scp command to copy the generated xml file does not turn off strict host key checking. This means any host that hasn't been seen already (e.g. newly created cloud instances) will get stuck asking the user if they should continue, a message the user can never see and never respond to, and the benchmark gets hung before it ever gets started. Adding
-o StrictHostKeyChecking=noskips this check and the command continues and the run completes.Before/After Comparison
Before: the wrapper would hang indefinitely, and a ps tree listing would show it's stuck in the 'scp xml1' command.
After: the benchmark run finishes successfully.
Clerical Stuff
Relates to JIRA: RPOPC-583
This closes #43