Skip to content

fix: add async setup() method to AsyncRedisSaver (#74) #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025

Conversation

bsbodden
Copy link
Contributor

Add async setup() method to AsyncRedisSaver that delegates to asetup() to match the canonical pattern used by PostgreSQL and SQLite checkpointers.

This fixes the RuntimeWarning caused by calling the inherited sync setup() method from BaseRedisSaver, which called async create() methods without awaiting them.

Maintains backward compatibility by keeping the existing asetup() method while providing the standard async setup() interface that users expect from LangGraph checkpointers.

Fixes #74

Add async setup() method to AsyncRedisSaver that delegates to asetup()
to match the canonical pattern used by PostgreSQL and SQLite checkpointers.

This fixes the RuntimeWarning caused by calling the inherited sync setup()
method from BaseRedisSaver, which called async create() methods without
awaiting them.

Maintains backward compatibility by keeping the existing asetup() method
while providing the standard async setup() interface that users expect
from LangGraph checkpointers.

Fixes #74
@bsbodden bsbodden requested a review from abrookins July 22, 2025 03:04
Copy link
Contributor

@abrookins abrookins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bsbodden bsbodden merged commit 4f990f1 into main Jul 22, 2025
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AsyncRedisSaver.setup() calls async methods without awaiting
2 participants