-
Notifications
You must be signed in to change notification settings - Fork 44
Upgrade redisvl and improve resource management #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Wierd -- when I implement the same updates to arxiv search I am seeing the warning/errors in the logs": https://github.com/redis-developer/redis-arXiv-search/actions/runs/13512854236/job/37756259025?pr=32 I must be doing something different/wrong there. My eyes are tired! Will check back in the morning. |
Ah, yes. FastAPI's lifespan context manager doesn't run during tests if you use There are some elaborate ways you can make the lifespan events fire during tests, but in our case, we can get away with an autouse Pytest fixture. Just pushed to your branch. As for the Pytest logging issue, there isn't a great way to prevent that, but we can use another fixture to help. I pushed one up. But because we're logging within other people's projects as a library, it may be worth suppressing the logging message in our weakref finalizer. |
To get around the lifespan issue, I had used the Only thing tripping me up is that I see the logging error/warning for the arxiv demo but not this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me maybe we can rubber duck on the warning you're getting in arxiv later.
Landed on using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
Uh oh!
There was an error while loading. Please reload this page.