-
Notifications
You must be signed in to change notification settings - Fork 384
RI-7039: replace eui #4548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pd-redis
wants to merge
131
commits into
main
Choose a base branch
from
fe/feature/RI-7039-replace-eui
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
RI-7039: replace eui #4548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # redisinsight/ui/src/components/connectivity-error/ConnectivityError.tsx # redisinsight/ui/src/components/inline-item-editor/InlineItemEditor.tsx # redisinsight/ui/src/components/item-list/components/delete-action/DeleteAction.tsx # redisinsight/ui/src/components/item-list/components/export-action/ExportAction.tsx # redisinsight/ui/src/components/query/query-actions/QueryActions.tsx # redisinsight/ui/src/components/query/query-card/QueryCardHeader/QueryCardHeader.tsx # redisinsight/ui/src/components/side-panels/panels/enablement-area/EnablementArea/components/InternalPage/InternalPage.tsx # redisinsight/ui/src/pages/browser/components/add-key/AddKeyHash/AddKeyHash.tsx # redisinsight/ui/src/pages/browser/components/add-key/AddKeyList/AddKeyList.tsx # redisinsight/ui/src/pages/browser/components/add-key/AddKeyReJSON/AddKeyReJSON.tsx # redisinsight/ui/src/pages/browser/components/add-key/AddKeySet/AddKeySet.tsx # redisinsight/ui/src/pages/browser/components/add-key/AddKeyStream/AddKeyStream.tsx # redisinsight/ui/src/pages/browser/components/add-key/AddKeyString/AddKeyString.tsx # redisinsight/ui/src/pages/browser/components/add-key/AddKeyZset/AddKeyZset.tsx # redisinsight/ui/src/pages/browser/modules/key-details/components/rejson-details/components/edit-entire-item-action/EditEntireItemAction.tsx # redisinsight/ui/src/pages/browser/modules/key-details/components/set-details/add-set-members/AddSetMembers.tsx # redisinsight/ui/src/pages/database-analysis/components/header/Header.tsx # redisinsight/ui/src/pages/home/components/database-list-header/DatabaseListHeader.tsx # redisinsight/ui/src/pages/home/components/database-manage-tags-modal/ManageTagsModal.tsx # redisinsight/ui/src/pages/settings/components/cloud-settings/CloudSettings.tsx # redisinsight/ui/src/pages/settings/components/cloud-settings/components/user-api-keys-table/UserApiKeysTable.tsx # redisinsight/ui/src/pages/slow-log/components/Actions/Actions.tsx
* RI-7058: expose redis ui Table component * update Table for TopKeys * use Table for TopNamespaces * use Table for UserApiKeysTable * use Table for TestConnectionsTable * use Table for TableResult * use Table for ClusterNodesTable * update Table for TableInfoResult * use Table for TableResult * use Table for ShortcutsTable * use Table for RedisClusterDatabasesPage * use Table for SentinelDatabasesResultPage * use Table for SentinelDatabasesPage * use Table for RedisCloudSubscriptionsPage * use Table for RedisCloudDatabasesResultPage * use Table for RedisCloudDatabasesPage * use Table for redisgraph * use Table for TableView * use Table for rdi tables
* replace eui tour step
* RI-7063: replace EuiPanel with Card * revert test ids
* add RadioGroup.tsx * replace EuiRadioGroup with RiRadioGroup * add redis-ui select * replace in EuiSuperSelect with RiSelect
* RI-7074: init RiTooltip * RI-7074: replace EuiTooltip with RITooltip * update unit tests * remove euiTooltip styles * fix failing tests * cleanup TODOs * resolve comments * remove EuiTooltip * expose TOOLTIP_DELAY_LONG constant
Code Coverage - Frontend unit tests
Test suite run success4829 tests passing in 632 suites. Report generated by 🧪jest coverage report action from c14102f |
Replace EuiAccordion with RiAccordion
* RI-7064: replace EuiPopup init * replace EuiPopup with RiPopup * fix some unit tests * skip some unit tests * remove EuiPopover reference * fix tests * fix onboarding popover
* RI-7074: expose anchorClassName for RiTooltip * revert anchorClassName prop usage for RiTooltip * revert missing styles * fix missing import
* create progress bar loader component * replace EuiProgress with ProgressBarLoader * apply the background color logic; this will be extracted and reused at a later point
* Export the sidebar component * Use SideBarItem for the existing menu items * add width and height props to side bar icon * remove the logo component - wasn't flexible enough to use in this case * remove the navigation item wrapper * fix the icon naming to be consistent, remove unneeded icons, make them work for both light and dark themes * wrap the create cloud component inside sidebar when rendering * change getIconType function to just iconType * remove leafIcon, which is a leftover of a previous UI redesign - #2706, Node.tsx file
* fix for the builds failing with redis ui * fix for the builds failing with redis ui
* replace EuiIcon
* replace EuiIcon in ExternalLink.tsx * remove console.log * temp * update Icon.tsx, RiIcon.tsx * add isSvg prop * replace EuiIcon * add some icons * refactor icons * replace icons * replace icons * replace icons * replace icons * remove icon files * fix SlowLogTable.spec.tsx matcher * move sidebar icons * move options icons * move modules icons * replace Icon with RiIcon * remove todo comment * remove todo comment * add back icons * fix issues after rebase * remove usage of htmlIdGenerator * remove unused files, fix tests * RI-7040: refactor icons to reduce technical debt * include missing icon --------- Co-authored-by: pd-redis <[email protected]>
* RI-7226: fix RiTooltip when content is empty * add unit tests for RiTooltip
* Update Electron from 33.2.0 to 36.4.0 and related dependencies - Update electron from EOL version 33.2.0 to supported 36.4.0 - Update electron-builder from 24.13.3 to 26.0.12 - Update electron-updater from 6.3.9 to 6.6.2 - Add node-abi 4.12.0 for better Electron version support - Update yarn.lock files with new dependency versions 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * rolled back local changes * rolled back local changes * Update Node.js version from 22.11.0 to 22.12.0 for node-abi compatibility The [email protected] package requires Node.js >=22.12.0 but CI was using 22.11.0. This update ensures compatibility with the upgraded Electron dependencies. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * Testing slightly different config to fix the resolutions after install * Fix electron-builder 26.0.12 configuration compatibility - Update Linux desktop configuration to use desktop.entry structure - Change Mac notarize from object to boolean (temporarily disabled) - Replace Windows publisherName with legalTrademarks - Remove electron-builder install-app-deps from postinstall script These changes address breaking changes in electron-builder 26.0.12. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * Restore Mac notarization and disable native module rebuilding - Restore Mac notarization with teamId configuration (good security practice) - Add npmRebuild: false, nodeGypRebuild: false, buildDependenciesFromSource: false to disable native module rebuilding which fails due to ABI compatibility issues - This allows electron-builder to proceed without trying to rebuild native modules like keytar and sqlite3 that cause ABI detection errors with Electron 36 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * Update Mac notarize configuration to boolean for electron-builder 26.0.12 In electron-builder 26.0.12, notarize must be a boolean value. The actual notarization configuration (teamId, etc.) is now handled via environment variables such as APPLE_TEAM_ID=UUK47G4BAZ instead of in the config file. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * Reverting unneeded changes * Reverting unneeded changes * reverting yarn.lock in the api folder for testing --------- Co-authored-by: Claude <[email protected]>
* RI-7212: replace EuiFormFieldset with FormFieldset * update display legend logic * add FormFieldset unit tests
* RI-7226: fix RiTooltip when title/content is empty * update test name
* Remove settings icons * fix keys summary alignment * entirely remove settings svgs
* replace EuiForm with form, replace eui/keys with uiSrc/constants/keys
* add RICollapsibleNavGroup * replace EuiCollapsibleNavGroup
* RI-7228 - key details - space is missing between Add / Cancel * RI-7228 - key details - space is missing between Add / Cancel * RI-7228 - key details - space is missing between Add / Cancel - returned classnames for test purposes
…oken styles and has blue square all over the screen (#4764)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the base branch where all ui updates should be merged initially before pushing back to main