Skip to content

RI-7039: replace eui #4548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 131 commits into
base: main
Choose a base branch
from
Open

RI-7039: replace eui #4548

wants to merge 131 commits into from

Conversation

pd-redis
Copy link
Collaborator

this is the base branch where all ui updates should be merged initially before pushing back to main

pd-redis added 30 commits May 7, 2025 12:28
# Conflicts:
#	redisinsight/ui/src/components/connectivity-error/ConnectivityError.tsx
#	redisinsight/ui/src/components/inline-item-editor/InlineItemEditor.tsx
#	redisinsight/ui/src/components/item-list/components/delete-action/DeleteAction.tsx
#	redisinsight/ui/src/components/item-list/components/export-action/ExportAction.tsx
#	redisinsight/ui/src/components/query/query-actions/QueryActions.tsx
#	redisinsight/ui/src/components/query/query-card/QueryCardHeader/QueryCardHeader.tsx
#	redisinsight/ui/src/components/side-panels/panels/enablement-area/EnablementArea/components/InternalPage/InternalPage.tsx
#	redisinsight/ui/src/pages/browser/components/add-key/AddKeyHash/AddKeyHash.tsx
#	redisinsight/ui/src/pages/browser/components/add-key/AddKeyList/AddKeyList.tsx
#	redisinsight/ui/src/pages/browser/components/add-key/AddKeyReJSON/AddKeyReJSON.tsx
#	redisinsight/ui/src/pages/browser/components/add-key/AddKeySet/AddKeySet.tsx
#	redisinsight/ui/src/pages/browser/components/add-key/AddKeyStream/AddKeyStream.tsx
#	redisinsight/ui/src/pages/browser/components/add-key/AddKeyString/AddKeyString.tsx
#	redisinsight/ui/src/pages/browser/components/add-key/AddKeyZset/AddKeyZset.tsx
#	redisinsight/ui/src/pages/browser/modules/key-details/components/rejson-details/components/edit-entire-item-action/EditEntireItemAction.tsx
#	redisinsight/ui/src/pages/browser/modules/key-details/components/set-details/add-set-members/AddSetMembers.tsx
#	redisinsight/ui/src/pages/database-analysis/components/header/Header.tsx
#	redisinsight/ui/src/pages/home/components/database-list-header/DatabaseListHeader.tsx
#	redisinsight/ui/src/pages/home/components/database-manage-tags-modal/ManageTagsModal.tsx
#	redisinsight/ui/src/pages/settings/components/cloud-settings/CloudSettings.tsx
#	redisinsight/ui/src/pages/settings/components/cloud-settings/components/user-api-keys-table/UserApiKeysTable.tsx
#	redisinsight/ui/src/pages/slow-log/components/Actions/Actions.tsx
KrumTy and others added 7 commits June 30, 2025 16:10
* RI-7058: expose redis ui Table component

* update Table for TopKeys

* use Table for TopNamespaces

* use Table for UserApiKeysTable

* use Table for TestConnectionsTable

* use Table for TableResult

* use Table for ClusterNodesTable

* update Table for TableInfoResult

* use Table for TableResult

* use Table for ShortcutsTable

* use Table for RedisClusterDatabasesPage

* use Table for SentinelDatabasesResultPage

* use Table for SentinelDatabasesPage

* use Table for RedisCloudSubscriptionsPage

* use Table for RedisCloudDatabasesResultPage

* use Table for RedisCloudDatabasesPage

* use Table for redisgraph

* use Table for TableView

* use Table for rdi tables
* replace eui tour step
* RI-7063: replace EuiPanel with Card

* revert test ids
* add RadioGroup.tsx

* replace EuiRadioGroup with RiRadioGroup

* add redis-ui select

* replace in EuiSuperSelect with RiSelect
* RI-7074: init RiTooltip

* RI-7074: replace EuiTooltip with RITooltip

* update unit tests

* remove euiTooltip styles

* fix failing tests

* cleanup TODOs

* resolve comments

* remove EuiTooltip

* expose TOOLTIP_DELAY_LONG constant
@pd-redis pd-redis requested a review from KIvanow July 8, 2025 13:05
Copy link
Contributor

github-actions bot commented Jul 9, 2025

Code Coverage - Frontend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 81.47% 18837/23121
🟡 Branches 66.92% 8233/12302
🟡 Functions 75.18% 4917/6540
🟢 Lines 81.88% 18437/22518

Test suite run success

4829 tests passing in 632 suites.

Report generated by 🧪jest coverage report action from c14102f

pd-redis and others added 2 commits July 9, 2025 18:34
Replace EuiAccordion with RiAccordion
* RI-7064: replace EuiPopup init

* replace EuiPopup with RiPopup

* fix some unit tests

* skip some unit tests

* remove EuiPopover reference

* fix tests

* fix onboarding popover
@KrumTy KrumTy requested a review from valkirilov as a code owner July 10, 2025 12:24
KrumTy and others added 17 commits July 10, 2025 16:18
* RI-7074: expose anchorClassName  for RiTooltip

* revert anchorClassName prop usage for RiTooltip

* revert missing styles

* fix missing import
* create progress bar loader component
* replace EuiProgress with ProgressBarLoader
* apply the background color logic; this will be extracted and reused at a later point
* Export the sidebar component
* Use SideBarItem for the existing menu items
* add width and height props to side bar icon
* remove the logo component - wasn't flexible enough to use in this case
* remove the navigation item wrapper
* fix the icon naming to be consistent, remove unneeded icons, make them work for both light and dark themes
* wrap the create cloud component inside sidebar when rendering
* change getIconType function to just iconType
* remove leafIcon, which is a leftover of a previous UI redesign - #2706, Node.tsx file
* fix for the builds failing with redis ui

* fix for the builds failing with redis ui
* replace EuiIcon
* replace EuiIcon in ExternalLink.tsx

* remove console.log

* temp

* update Icon.tsx, RiIcon.tsx

* add isSvg prop

* replace EuiIcon

* add some icons

* refactor icons

* replace icons

* replace icons

* replace icons

* replace icons

* remove icon files

* fix SlowLogTable.spec.tsx matcher

* move sidebar icons

* move options icons

* move modules icons

* replace Icon with RiIcon

* remove todo comment

* remove todo comment

* add back icons

* fix issues after rebase

* remove usage of htmlIdGenerator

* remove unused files, fix tests

* RI-7040: refactor icons to reduce technical debt

* include missing icon

---------

Co-authored-by: pd-redis <[email protected]>
* RI-7226: fix RiTooltip when content is empty

* add unit tests for RiTooltip
* Update Electron from 33.2.0 to 36.4.0 and related dependencies

- Update electron from EOL version 33.2.0 to supported 36.4.0
- Update electron-builder from 24.13.3 to 26.0.12
- Update electron-updater from 6.3.9 to 6.6.2
- Add node-abi 4.12.0 for better Electron version support
- Update yarn.lock files with new dependency versions

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* rolled back local changes

* rolled back local changes

* Update Node.js version from 22.11.0 to 22.12.0 for node-abi compatibility

The [email protected] package requires Node.js >=22.12.0 but CI was using 22.11.0.
This update ensures compatibility with the upgraded Electron dependencies.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* Testing slightly different config to fix the resolutions after install

* Fix electron-builder 26.0.12 configuration compatibility

- Update Linux desktop configuration to use desktop.entry structure
- Change Mac notarize from object to boolean (temporarily disabled)
- Replace Windows publisherName with legalTrademarks
- Remove electron-builder install-app-deps from postinstall script

These changes address breaking changes in electron-builder 26.0.12.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* Restore Mac notarization and disable native module rebuilding

- Restore Mac notarization with teamId configuration (good security practice)
- Add npmRebuild: false, nodeGypRebuild: false, buildDependenciesFromSource: false
  to disable native module rebuilding which fails due to ABI compatibility issues
- This allows electron-builder to proceed without trying to rebuild native modules
  like keytar and sqlite3 that cause ABI detection errors with Electron 36

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* Update Mac notarize configuration to boolean for electron-builder 26.0.12

In electron-builder 26.0.12, notarize must be a boolean value. The actual
notarization configuration (teamId, etc.) is now handled via environment
variables such as APPLE_TEAM_ID=UUK47G4BAZ instead of in the config file.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* Reverting unneeded changes

* Reverting unneeded changes

* reverting yarn.lock in the api folder for testing

---------

Co-authored-by: Claude <[email protected]>
* RI-7212: replace EuiFormFieldset with FormFieldset

* update display legend logic

* add FormFieldset unit tests
* RI-7226: fix RiTooltip when title/content is empty

* update test name
* Remove settings icons
* fix keys summary alignment
* entirely remove settings svgs
* replace EuiForm with form, replace eui/keys with uiSrc/constants/keys
* add RICollapsibleNavGroup

* replace EuiCollapsibleNavGroup
* RI-7228 - key details - space is missing between Add / Cancel

* RI-7228 - key details - space is missing between Add / Cancel

* RI-7228 - key details - space is missing between Add / Cancel - returned classnames for test purposes
…oken styles and has blue square all over the screen (#4764)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants