RI-7213: replace EuiImage with img tag #4760
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantovska
requested review from
KrumTy,
pawelangelow,
ArtemHoruzhenko,
pd-redis and
KIvanow
as code owners
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Code Coverage - Frontend unit tests
Test suite run success4829 tests passing in 632 suites. Report generated by 🧪jest coverage report action from 76a8ac9 |
valkirilov
previously approved these changes
Jul 28, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
valkirilov
previously approved these changes
Jul 28, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR replaces all instances of the EuiImage component from Elastic UI with a custom RiImage component. The change maintains visual consistency while replacing the external dependency with an internal implementation.
- Removes EuiImage imports and replaces with RiImage from internal components
- Creates a new RiImage component with size variants (s, m, l, xl, original, fullWidth)
- Updates the display components index to export the new RiImage component
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| redisinsight/ui/src/pages/rdi/statistics/empty/Empty.tsx | Replace EuiImage with RiImage for empty pipeline icon |
| redisinsight/ui/src/pages/rdi/home/empty-message/EmptyMessage.tsx | Replace EuiImage with RiImage for empty message icon |
| redisinsight/ui/src/pages/home/components/empty-message/EmptyMessage.tsx | Replace EuiImage with RiImage for database empty state |
| redisinsight/ui/src/pages/browser/components/virtual-tree/VirtualTree.tsx | Replace EuiImage with RiImage for loading icon |
| redisinsight/ui/src/pages/browser/components/no-keys-found/NoKeysFound.tsx | Replace EuiImage with RiImage for telescope image |
| redisinsight/ui/src/components/oauth/shared/oauth-advantages/OAuthAdvantages.tsx | Replace EuiImage with RiImage for Redis logo |
| redisinsight/ui/src/components/oauth/oauth-sign-in-button/OAuthSignInButton.tsx | Replace EuiImage with RiImage for sign-in button logo |
| redisinsight/ui/src/components/base/display/index.ts | Export new RiImage component |
| redisinsight/ui/src/components/base/display/image/image.styles.ts | Define styled components and types for RiImage |
| redisinsight/ui/src/components/base/display/image/RiImage.tsx | Implement RiImage component |
valkirilov
previously approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply replacing EuiImage with img tag, no difference visually.