RI-7400: Change font size/colors across the app #1 #4992
Conversation
ArtemHoruzhenko
requested review from
KrumTy,
pawelangelow,
dantovska,
pd-redis and
valkirilov
as code owners
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
Code Coverage - Frontend unit tests
Test suite run success5152 tests passing in 677 suites. Report generated by 🧪jest coverage report action from 652f42b |
|
|
||
| if (rowIndex === 0) { | ||
| const isLastColumn = columns.length - 1 === columnIndex | ||
| console.log('____ content', content) |
There was a problem hiding this comment.
I guess this is left by mistake?
There was a problem hiding this comment.
nope, it was planned. ask @valkirilov
| import MessageAckPopover from './MessageAckPopover' | ||
|
|
||
| import styles from './MessagesView/styles.module.scss' | ||
| import {numberWithSpaces} from 'uiSrc/utils/numbers' |
There was a problem hiding this comment.
nit: is this formatted? I guess format displays it like this:
import { numberWithSpaces } from 'uiSrc/utils/numbers'
also, could be rearanged and moved before styles import.
This should be because of the JSON formatter set for your hashes. |
ArtemHoruzhenko
deleted the
fe/feature/RI-7400-change-fonts-color-sizes-across-app
branch
In this PR key details for all key types were covered