newConn race fix, fix check pool exhausted, replacing the MaxActiveConns parameter with PoolSizeStrict #2781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvorobev
changed the title
nvorobev
changed the title
Collaborator
|
@nvorobev Could you please add unit tests for this issue? |
Member
|
@nvorobev thank you for the contribution, please add tests so we can review the PR and proceed. |
ndyakov
requested changes
Mar 19, 2025
Comment on lines
+182
to
+187
| // It is not allowed to add new connections to the closed connection pool. | ||
| if p.closed() { | ||
| _ = cn.Close() | ||
| return nil, ErrClosed | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
it should check if pool is closed before potential dialconn call.
Member
|
It has been couple of months, closing this as stale PR. @nvorobev feel free to open a new one based on the latest state of master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library implements non-standard pool behavior. Where the pool size is essentially not an honest pool size and can increase without limitation, which under heavy loads will lead to the server being flooded with connections.
PoolSizeStrict - enabling classic pool mode, when it is guaranteed that no more connections will open to the server than specified in PoolSize.
An example of classic pool behavior:
https://github.com/gomodule/redigo/blob/master/redis/pool.go#L147C1-L147C1
https://github.com/gomodule/redigo/blob/master/redis/pool.go#L247