DOC-5472 time series doc examples #3443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @andy-stark-redis , I will review this till end of week. Thank you. |
ndyakov
reviewed
Jul 30, 2025
There was a problem hiding this comment.
@andy-stark-redis I left some styling suggestions on the first occurrences of the patterns that I observed. Feel free to address them for the rest of the examples. Mainly - remove empty lines before checking the error and if the method arguments are on multiple lines, keep them one per line. Other than that, looks good to me.
ofekshenawa
pushed a commit
that referenced
this pull request
Aug 10, 2025
* DOC-5472 added and fixed tests up to * DOC-5472 added agg bucket examples * DOC-5472 time series doc examples * DOC-5472 removed black lines above error checks, following feedback * DOC-5472 fixed param formatting, following feedback --------- Co-authored-by: Nedyalko Dyakov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOC-5472
Go versions of the Python examples in the time series doc page.
Couple of things to note:
math.MaxInt64instead of-and+for minimum/maximum timestamps is OK (eg, line 211), but if there's a better way to specify this then let me know.TSMGet/TSMRangeexamples return maps, so the ordering keys in nondeterministic. I've used code that's a bit more complicated than usual to print out the results in a deterministic way (eg, the example at line 438). If there's a simpler or more idiomatic way to handle this situation then I'll use that instead.