Skip to content

Conversation

The-East-Wind
Copy link
Contributor

@The-East-Wind The-East-Wind commented Jun 24, 2025

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

Changes

  1. Removed usages of ClientResources#dnsResolver
  2. Removed ClientResources#dnsResolver and all of it's implementations in DefaultClientResources
  3. Removed redundant classes which are no longer relevant
  4. Removed deprecated JVM_DEFAULT DnsResolver
  5. Fixed failing tests

Followup questions for maintainers

  1. Should DnsResolver and it's implementations be removed or should they continue to exist
  2. If DnsResolver is to be removed should SockerAddressResolver make direct use of netty's AddressResolverGroup

@tishun tishun added this to the 7.0.0.RELEASE milestone Jul 11, 2025
@tishun tishun added the type: breaking Breaking change label Jul 11, 2025
@tishun tishun merged commit e15360f into redis:main Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: breaking Breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants