-
Notifications
You must be signed in to change notification settings - Fork 1k
chore: remove usage of deprecated connection methods in command APIs in integration tests (#3328) #3343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: remove usage of deprecated connection methods in command APIs in integration tests (#3328) #3343
Conversation
Hey @The-East-Wind , which of the tasks in #3328 does this PR address? |
@tishun This aims to partially address |
Hey @The-East-Wind , yes, I think this is the correct approach. Do you have something specific that you are concerned about? |
@tishun the number of places which required change was high so I wanted to confirm I was following the right approach before make all the changes so that there is no rework. I was specifically concerned about using |
…n client, pubsub, advanced cluster and at most one integration tests Signed-off-by: The-East-Wind <[email protected]>
…ntations from async commands API Signed-off-by: The-East-Wind <[email protected]>
…tion methods from command APIs Signed-off-by: The-East-Wind <[email protected]>
…thods in integration tests Signed-off-by: The-East-Wind <[email protected]>
…mmands API impl Signed-off-by: The-East-Wind <[email protected]>
Signed-off-by: The-East-Wind <[email protected]>
Signed-off-by: The-East-Wind <[email protected]>
…and cluster command APIs Signed-off-by: The-East-Wind <[email protected]>
907eebd
to
6851931
Compare
Make sure that:
mvn formatter:format
target. Don’t submit any formatting related changes.Partially resolves #3328
Changes
flushCommands
,isOpen
,setAutoFlushCommands
andclose
in integration tests and changed to use alternate methods fromStatefulRedisConnection
andStatefulRedisClusterConnection
.isOpen
in set client name flow for cluster commandsgetStatefulConnection
from integration testsflushCommands
,isOpen
,setAutoFlushCommands
andclose
methods from command APIsFollow up
getStatefulConnection
is still being used in > 50 integration tests, this is to be removed before the method can be removed from the command APIs