fix: handle predicate negation and TAG field notEq operations in Enti… #669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tyStream
- Add NegatedPredicate class to properly handle SearchFieldPredicate negation
- Override negate() in BaseAbstractPredicate to preserve SearchFieldPredicate type
- Fix ClassCastException in NotEqualPredicate.getValues() for single values
- Add comprehensive tests for isMissing().negate() and notEq("") operations
- Document missing field queries in EntityStream documentation
The issue occurred when isMissing().negate() was called, as it used Java's default
Predicate.negate() which wrapped the predicate in a generic negation, losing the
SearchFieldPredicate type needed for proper query generation. This caused the
EntityStream to generate wildcard "*" queries instead of proper "-ismissing(@field)"
queries.
Additionally fixed a ClassCastException in NotEqualPredicate when using notEq("")
with single string values by properly checking if the value is already iterable
before casting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tyStream
The issue occurred when isMissing().negate() was called, as it used Java's default Predicate.negate() which wrapped the predicate in a generic negation, losing the SearchFieldPredicate type needed for proper query generation. This caused the EntityStream to generate wildcard "*" queries instead of proper "-ismissing(@field)" queries.
Additionally fixed a ClassCastException in NotEqualPredicate when using notEq("") with single string values by properly checking if the value is already iterable before casting.