Skip to content

BAU-27505 Fix Server-Side Request Forgery (SSRF) / Path Traversal issues #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

BAU-27505 Fix Server-Side Request Forgery (SSRF) / Path Traversal issues #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions example-wrapper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,9 +166,29 @@ public function stream_seek($offset, $whence) {

private function __getURL($path) {
$this->url = parse_url($path);
if (!isset($this->url['scheme']) || $this->url['scheme'] !== 's3') return $this->url;
if (isset($this->url['user'], $this->url['pass'])) self::setAuth($this->url['user'], $this->url['pass']);
$this->url['path'] = isset($this->url['path']) ? substr($this->url['path'], 1) : '';

// Only allow 's3' scheme
if (!isset($this->url['scheme']) || $this->url['scheme'] !== 's3') {
throw new InvalidArgumentException('Invalid scheme: only s3:// is allowed');
}

// Validate bucket name
if (
!isset($this->url['host']) ||
!preg_match('/^(?!^\d+\.\d+\.\d+\.\d+$)(?!.*\.\.)(?!.*\.$)(?!^\.)[a-z0-9]([a-z0-9.-]{1,61}[a-z0-9])?$/', $this->url['host'])
) {
throw new InvalidArgumentException('Invalid S3 bucket name');
}

// Validate path (no directory traversal)
$this->url['path'] = isset($this->url['path']) ? ltrim($this->url['path'], '/') : '';
if (strpos($this->url['path'], '..') !== false) {
throw new InvalidArgumentException('Invalid S3 object path');
}

if (isset($this->url['user'], $this->url['pass'])) {
self::setAuth($this->url['user'], $this->url['pass']);
}
}

private function __translateMode($mode) {
Expand Down