-
Notifications
You must be signed in to change notification settings - Fork 12
DOC-1065 Enabling connectivity for cloud-based external systems #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
asimms41
wants to merge
1
commit into
main
Choose a base branch
from
DOC-1065_External_connectivity
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -84,6 +84,7 @@ output: | |
| -- | ||
| ====== | ||
|
|
||
| include::components:partial$external_connectivity_outputs.adoc[] | ||
|
|
||
| == Performance | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
modules/components/partials/external_connectivity_inputs.adoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| ifndef::env-cloud[] | ||
|
|
||
| == Enable connectivity from cloud-based data sources | ||
|
|
||
| To establish a secure connection between a cloud-based data source and Redpanda Connect, you must add the IP addresses of your Redpanda Connect instances to your firewall rules. | ||
|
|
||
| endif::[] | ||
|
|
||
| ifdef::env-cloud[] | ||
|
|
||
| == Enable connectivity from cloud-based data sources (BYOC only) | ||
|
|
||
| To establish a secure connection between a cloud-based data source and Redpanda Connect, you must add the NAT Gateway IP address of your Redpanda cluster to the allowlist of your data source. | ||
|
|
||
| endif::[] | ||
15 changes: 15 additions & 0 deletions
15
modules/components/partials/external_connectivity_outputs.adoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| ifndef::env-cloud[] | ||
|
|
||
| == Enable connectivity to cloud-based data sinks | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've added this message to a small set of outputs for now. Again, any guidance on which other data sinks this should be added to would be appreciated. |
||
|
|
||
| To establish a secure connection between Redpanda Connect and a cloud-based target system, you must add the IP addresses of your Redpanda Connect instances to your firewall rules. | ||
|
|
||
| endif::[] | ||
|
|
||
| ifdef::env-cloud[] | ||
|
|
||
| == Enable connectivity to cloud-based data sinks (BYOC only) | ||
|
|
||
| To establish a secure connection between Redpanda Connect and a cloud-based target system, you must add the NAT Gateway IP address of your Redpanda cluster to the allowlist of your data sink. | ||
|
|
||
| endif::[] | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added this message to just the timeplus input for now. See page previews for cloud and non-cloud versions. I skimmed through the list but wasn't entirely sure which connectors it might apply to, it didn't seem relevant in many cases. Any guidance appreciated: https://github.com/redpanda-data/connect/blob/main/internal/plugins/info.csv