Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the summary part of the document, where it is stated: "Loading state should usually be stored as an enum, like 'idle' | 'pending' | 'succeeded' | 'rejected'". It is important to realize that the example given wasn't a TypeScript enum, but TypeScript's union of string literals. The documentation should be updated to reflect this.
name: 📝 Documentation Fix
about: Fixing a problem in an existing docs page
Checklist
What docs page needs to be fixed?
What is the problem?
'idle' | 'pending' | 'succeeded' | 'rejected' is not an enum but a union of string literals.
What changes does this PR make to fix the problem?
Updates the statement to become: "Loading state should usually be stored as a union of string literals, like 'idle' | 'pending' | 'succeeded' | 'rejected'"