Skip to content

Conversation

BonaventureCJ
Copy link
Contributor

At the summary part of the document, where it is stated: "Loading state should usually be stored as an enum, like 'idle' | 'pending' | 'succeeded' | 'rejected'". It is important to realize that the example given wasn't a TypeScript enum, but TypeScript's union of string literals. The documentation should be updated to reflect this.


name: 📝 Documentation Fix
about: Fixing a problem in an existing docs page

Checklist

  • Is there an existing issue for this PR?
    • link issue here
  • Have the files been linted and formatted?

What docs page needs to be fixed?

What is the problem?

'idle' | 'pending' | 'succeeded' | 'rejected' is not an enum but a union of string literals.

What changes does this PR make to fix the problem?

Updates the statement to become: "Loading state should usually be stored as a union of string literals, like 'idle' | 'pending' | 'succeeded' | 'rejected'"

At the summary part of the document, where it is stated: "Loading state should usually be stored as an enum, like 'idle' | 'pending' | 'succeeded' | 'rejected'". It is important to realize that the example given wasn't a TypeScript enum, but TypeScript's union of string literals. The documentation should be updated to reflect this.
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

netlify bot commented Aug 23, 2025

Deploy Preview for redux-docs ready!

Name Link
🔨 Latest commit bf19998
🔍 Latest deploy log https://app.netlify.com/projects/redux-docs/deploys/68a9ad6b5631b500080729e2
😎 Deploy Preview https://deploy-preview-4807--redux-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@timdorr
Copy link
Member

timdorr commented Aug 25, 2025

Thanks!

@timdorr timdorr merged commit 77e0602 into reduxjs:master Aug 25, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants