Skip to content

Conversation

@bricesanchez
Copy link
Member

Hello all !

In addition to my PR refinery/refinerycms-i18n#51

I suggest this solution to add localized routes on refinerycms engine.

It will be great if the ActionDispatch::Routing::Mapper::localizable method will be directly added in refinerycms core to avoid duplicate code.

No need to fork route_translator with this solution :)

@parndt @simi

@parndt
Copy link
Member

parndt commented Dec 5, 2014

Could we hook into the draw method and do this for the developer, in some way?

@simi
Copy link
Member

simi commented Dec 5, 2014

Does the reloader works for this change in dev?

@bricesanchez
Copy link
Member Author

@parndt it will be great if it's possible. If it's working we could only change refinerycms-i18n

@bricesanchez
Copy link
Member Author

@simi What do you mean by reloader works ?

@simi
Copy link
Member

simi commented Dec 5, 2014

https://github.com/rails/rails/blob/master/actionpack/lib/action_dispatch/middleware/reloader.rb

Start dummy app, change route and try to reload page in dev.

@bricesanchez
Copy link
Member Author

@simi it works.

@parndt
Copy link
Member

parndt commented Aug 24, 2015

@bricesanchez do you still like this solution?

@bricesanchez
Copy link
Member Author

@parndt i will check this soon but i always need this feature.

@bricesanchez bricesanchez self-assigned this Jan 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants