-
Couldn't load subscription status.
- Fork 116
[enhancement] Only print performance variable reference values if defined #3517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
[enhancement] Only print performance variable reference values if defined #3517
Conversation
…re all defined Signed-off-by: Jack Morrison <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3517 +/- ##
===========================================
+ Coverage 91.16% 91.38% +0.22%
===========================================
Files 62 62
Lines 13253 13360 +107
===========================================
+ Hits 12082 12209 +127
+ Misses 1171 1151 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| msg = f'P: {name}: {val} {unit} (r:{ref}, l:{lower}, u:{upper})' | ||
|
|
||
| # Build reference info string only if all three reference value components are defined | ||
| if ref is not None and lower is not None and upper is not None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would change the check here to
| if ref is not None and lower is not None and upper is not None: | |
| if ref is not None: |
Because otherwise it will mask out cases where the reference is set, but not the thresholds. Also are you sure that checking the reference against None is correct. I think when it's missing we are setting it to 0:
reframe/reframe/core/pipeline.py
Line 2440 in e3c4b30
| ref = (0, None, None) |
Prior to change
A test without reference values prints
(r:0, l:None, u:None)for each performance variable. This is #3175.After change
A test without reference values does not print the reference tuple. Only the captured performance metric is printed.
A test with reference values behaves as before. The captured performance metric and its references are both printed.
Closes #3175