Fix missing trace.id/span.id in NewRelic logs #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These let NewRelic tie log messages to specific transactions. They're thread-local, so trying to capture them from an async appender thread would return nil
jdelStrother
force-pushed
the
newrelic-metadata
branch
from
d4fa5dd to
8989e7c
Compare
|
Anything I can do to help get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if available)
Followup to #307
Description of changes
trace.id/span.idare useful in NewRelic for tying log messages to specific transactions, but they're always nil with the current newrelic log formatter. You can get them fromNewRelic::Agent.linking_metadata, but it's thread-local data, so trying to do so from the background logger thread is too late.Instead, store it on the
Loginstance as soon as a log message is created.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.