-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
docs(api/hooks): auto-generate docs for DOM-related hooks #13987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
MichaelDeBoey
wants to merge
2
commits into
remix-run:dev
from
MichaelDeBoey:auto-generate-docs-for-DOM-related-hooks
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,17 @@ title: useFormAction | |
|
||
# useFormAction | ||
|
||
<!-- | ||
⚠️ ⚠️ IMPORTANT ⚠️ ⚠️ | ||
|
||
Hey! Thank you for helping improve our documentation! | ||
|
||
This file is auto-generated from the JSDoc comments in the source | ||
code, so please find the definition of this API and edit the JSDoc | ||
comments accordingly and this file will be re-generated once those | ||
changes are merged. | ||
--> | ||
|
||
[MODES: framework, data] | ||
|
||
## Summary | ||
|
@@ -12,7 +23,7 @@ title: useFormAction | |
|
||
Resolves the URL to the closest route in the component hierarchy instead of the current URL of the app. | ||
|
||
This is used internally by [Form](../components/Form) resolve the action to the closest route, but can be used generically as well. | ||
This is used internally by [`Form`](../components/Form) resolve the `action` to the closest route, but can be used generically as well. | ||
|
||
```tsx | ||
import { useFormAction } from "react-router"; | ||
|
@@ -29,19 +40,16 @@ function SomeComponent() { | |
## Signature | ||
|
||
```tsx | ||
useFormAction(action, __namedParameters): string | ||
useFormAction() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same |
||
``` | ||
|
||
## Params | ||
|
||
### action | ||
|
||
[modes: framework, data] | ||
|
||
The action to append to the closest route URL. | ||
The action to append to the closest route URL. If not provided, defaults to the closest route URL. | ||
|
||
### \_\_namedParameters | ||
### options.relative | ||
|
||
[modes: framework, data] | ||
The relative routing type to use when resolving the action. Defaults to `"route"`. | ||
|
||
_No documentation_ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something seems off in the
getSignature
code when there are comments in the types 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a bummer - but we shouldn't need to inline document them anymore since we're now doing it at the
@params
tagThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll make these updates too 👍