fix: social login not working with wallet buttong #5148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e95f96f The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
10 Skipped Deployments
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where social login functionality was not working properly with the wallet button. The issue was related to incorrect data retrieval from ChainController when setting social provider and social window properties.
- Reordered ChainController calls to ensure proper data retrieval after setting properties
- Added comprehensive test coverage for the connectSocial functionality
- Updated changeset documentation to reflect the bug fix
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/controllers/src/utils/ConnectorControllerUtil.ts | Fixed order of operations to retrieve account data after setting properties |
| packages/controllers/tests/utils/ConnectorControllerUtil.test.ts | Added test coverage for connectSocial functionality |
| .changeset/brown-roses-report.md | Added changeset documentation for the bug fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tomiir
reviewed
Oct 3, 2025
tomiir
reviewed
Oct 3, 2025
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue where social login did not work with wallet button
Type of change
Associated Issues
For Linear issues: Closes APKT-3986
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist
Note
Refactors
connectSocialto correctly handle provider, popup, and events for social login with the wallet button, and adds unit tests for the flow.packages/controllers/src/utils/ConnectorControllerUtil.ts:connectSocial:socialassocialProvider; stop readingsocialProvider/socialWindowfrom account state.socialWindowlocally; removevaltioref).SOCIAL_LOGIN_*events withprovider.connectExternalwith receivedresultUri.packages/controllers/tests/utils/ConnectorControllerUtil.test.ts:connectSocialtests to verifygetSocialRedirectUriis called and update mocks/setup.@reown/*packages; note fix for social login with wallet button.Written by Cursor Bugbot for commit e95f96f. This will update automatically on new commits. Configure here.