-
Couldn't load subscription status.
- Fork 1.6k
chore: update wallet impression event name to v2 #5149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
10 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the wallet impression event name from 'WALLET_IMPRESSION' to 'WALLET_IMPRESSION_V2' across the codebase. This appears to be a versioning change for telemetry/analytics events.
- Updated event type definition in TypeUtil.ts
- Updated event implementation in EventsController.ts
- Updated related documentation comment
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/controllers/src/utils/TypeUtil.ts | Updates event type definition from 'WALLET_IMPRESSION' to 'WALLET_IMPRESSION_V2' |
| packages/controllers/src/controllers/EventsController.ts | Updates event implementation and documentation to use 'WALLET_IMPRESSION_V2' |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
📦 Bundle Size Check✅ All bundles are within size limits 📊 View detailed bundle sizes> @reown/[email protected] size /home/runner/work/appkit/appkit > size-limit |
Description
Please include a brief summary of the change.
Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist
Note
Renames wallet impression tracking event from
WALLET_IMPRESSIONtoWALLET_IMPRESSION_V2across event batching and types._transformPendingEventsForBatchfilter and_submitPendingEventsbatch payload to useWALLET_IMPRESSION_V2.Eventunion inpackages/controllers/src/utils/TypeUtil.tstoevent: 'WALLET_IMPRESSION_V2'.EventsController.Written by Cursor Bugbot for commit 5225705. This will update automatically on new commits. Configure here.