Skip to content

Conversation

@enesozturk
Copy link
Contributor

@enesozturk enesozturk commented Oct 3, 2025

Description

Please include a brief summary of the change.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Note

Renames wallet impression tracking event from WALLET_IMPRESSION to WALLET_IMPRESSION_V2 across event batching and types.

  • Analytics Events:
    • Batching: Update _transformPendingEventsForBatch filter and _submitPendingEvents batch payload to use WALLET_IMPRESSION_V2.
    • Types: Change Event union in packages/controllers/src/utils/TypeUtil.ts to event: 'WALLET_IMPRESSION_V2'.
    • Minor: Update related doc comment in EventsController.

Written by Cursor Bugbot for commit 5225705. This will update automatically on new commits. Configure here.

Copilot AI review requested due to automatic review settings October 3, 2025 14:42
@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2025

⚠️ No Changeset found

Latest commit: 5225705

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
appkit-basic-html Ready Ready Preview Comment Oct 7, 2025 9:14am
appkit-demo Ready Ready Preview Comment Oct 7, 2025 9:14am
appkit-gallery Ready Ready Preview Comment Oct 7, 2025 9:14am
appkit-laboratory Ready Ready Preview Comment Oct 7, 2025 9:14am
10 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
appkit-basic-example Ignored Ignored Oct 7, 2025 9:14am
appkit-basic-sign-client-example Ignored Ignored Oct 7, 2025 9:14am
appkit-basic-up-example Ignored Ignored Oct 7, 2025 9:14am
appkit-ethers5-bera Ignored Ignored Oct 7, 2025 9:14am
appkit-nansen-demo Ignored Ignored Oct 7, 2025 9:14am
appkit-vue-solana Ignored Ignored Oct 7, 2025 9:14am
appkit-wagmi-cdn-example Ignored Ignored Oct 7, 2025 9:14am
ethereum-provider-wagmi-example Ignored Ignored Oct 7, 2025 9:14am
next-wagmi-solana-bitcoin-example Ignored Ignored Oct 7, 2025 9:14am
vue-wagmi-example Ignored Ignored Oct 7, 2025 9:14am

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the wallet impression event name from 'WALLET_IMPRESSION' to 'WALLET_IMPRESSION_V2' across the codebase. This appears to be a versioning change for telemetry/analytics events.

  • Updated event type definition in TypeUtil.ts
  • Updated event implementation in EventsController.ts
  • Updated related documentation comment

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/controllers/src/utils/TypeUtil.ts Updates event type definition from 'WALLET_IMPRESSION' to 'WALLET_IMPRESSION_V2'
packages/controllers/src/controllers/EventsController.ts Updates event implementation and documentation to use 'WALLET_IMPRESSION_V2'

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

cursor[bot]

This comment was marked as outdated.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 79.97% 36580 / 45740
🔵 Statements 79.97% 36580 / 45740
🔵 Functions 78.36% 4021 / 5131
🔵 Branches 86.56% 8814 / 10182
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/controllers/src/controllers/EventsController.ts 89.57% 95.65% 88.23% 89.57% 106-107, 141-142, 154-165, 208, 163
Generated in workflow #15597 for commit 5225705 by the Vitest Coverage Report Action

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

📦 Bundle Size Check

All bundles are within size limits

📊 View detailed bundle sizes

> @reown/[email protected] size /home/runner/work/appkit/appkit


> size-limit

@reown/appkit - Main Entry
Size limit:   80 kB
Size:         73.9 kB with all dependencies, minified and gzipped
Loading time: 1.5 s   on slow 3G
Running time: 2.4 s   on Snapdragon 410
Total time:   3.8 s
@reown/appkit/react
Size limit:   230 kB
Size:         222.22 kB with all dependencies, minified and gzipped
Loading time: 4.4 s     on slow 3G
Running time: 5.4 s     on Snapdragon 410
Total time:   9.8 s
@reown/appkit/vue
Size limit:   80 kB
Size:         73.9 kB with all dependencies, minified and gzipped
Loading time: 1.5 s   on slow 3G
Running time: 2.5 s   on Snapdragon 410
Total time:   3.9 s
@reown/appkit-scaffold-ui
Size limit:   220 kB
Size:         201 kB with all dependencies, minified and gzipped
Loading time: 4 s    on slow 3G
Running time: 3 s    on Snapdragon 410
Total time:   7 s
@reown/appkit-ui
Size limit:   500 kB
Size:         12.99 kB with all dependencies, minified and gzipped
Loading time: 254 ms   on slow 3G
Running time: 258 ms   on Snapdragon 410
Total time:   512 ms

@enesozturk enesozturk enabled auto-merge October 7, 2025 09:19
@enesozturk enesozturk added this pull request to the merge queue Oct 7, 2025
Merged via the queue into main with commit f434f36 Oct 7, 2025
43 checks passed
@enesozturk enesozturk deleted the chore/wallet-impression-event-name branch October 7, 2025 09:54
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants