Skip to content

Conversation

@screspod
Copy link
Member

@screspod screspod commented Oct 17, 2025

What this PR does / why we need it:

Changes the namespace of the kots and app deployment from "kotsadm" to the app's slug for new installations in V3. During upgrades, the "kotsadm" namespace is used if it exists, otherwise the app's slug.

Which issue(s) this PR fixes:

https://app.shortcut.com/replicated/story/109550/deploy-kots-and-app-to-namespace-named-appslug-instead-of-kotsadm

Does this PR require a test?

yes

Does this PR require a release note?

NONE

Does this PR require documentation?

NONE

f
Signed-off-by: Steven Crespo <[email protected]>
@github-actions
Copy link

github-actions bot commented Oct 17, 2025

This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID.

Online Installer:

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci/appver-dev-9c5afc3" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Airgap Installer (may take a few minutes before the airgap bundle is built):

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci-airgap/appver-dev-9c5afc3?airgap=true" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Happy debugging!

@screspod screspod marked this pull request as ready for review October 17, 2025 22:37
cursor[bot]

This comment was marked as outdated.

f
Signed-off-by: Steven Crespo <[email protected]>
cursor[bot]

This comment was marked as outdated.

f
Signed-off-by: Steven Crespo <[email protected]>
f
Signed-off-by: Steven Crespo <[email protected]>
@screspod screspod requested a review from sgalsaleh October 22, 2025 17:44
f
Signed-off-by: Steven Crespo <[email protected]>
cursor[bot]

This comment was marked as outdated.

f
Signed-off-by: Steven Crespo <[email protected]>
f
Signed-off-by: Steven Crespo <[email protected]>
// If there's none skip the remainder of the test
if loopbackInterface == nil {
t.Skip("no loopback interface found on system")
return
Copy link
Member Author

@screspod screspod Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added this to address a golangci-lint error in Sanitize

f
Signed-off-by: Steven Crespo <[email protected]>
cursor[bot]

This comment was marked as outdated.

f
Signed-off-by: Steven Crespo <[email protected]>
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

f
Signed-off-by: Steven Crespo <[email protected]>
f
Signed-off-by: Steven Crespo <[email protected]>
f
Signed-off-by: Steven Crespo <[email protected]>
cursor[bot]

This comment was marked as outdated.

f
Signed-off-by: Steven Crespo <[email protected]>
cursor[bot]

This comment was marked as outdated.

f
Signed-off-by: Steven Crespo <[email protected]>
cursor[bot]

This comment was marked as outdated.

f
Signed-off-by: Steven Crespo <[email protected]>
f
Signed-off-by: Steven Crespo <[email protected]>
f
Signed-off-by: Steven Crespo <[email protected]>
cursor[bot]

This comment was marked as outdated.

f
Signed-off-by: Steven Crespo <[email protected]>
@screspod screspod requested a review from sgalsaleh October 24, 2025 15:28
f
Signed-off-by: Steven Crespo <[email protected]>
f
Signed-off-by: Steven Crespo <[email protected]>
@screspod screspod requested a review from sgalsaleh October 24, 2025 22:23
@screspod screspod merged commit 20cd4b8 into main Oct 27, 2025
146 of 148 checks passed
@screspod screspod deleted the screspod/sc-109550/deploy-kots-and-app-to-namespace-named-appslug branch October 27, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants