-
Notifications
You must be signed in to change notification settings - Fork 8
Deploy kots and app to namespace named appslug #3070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy kots and app to namespace named appslug #3070
Conversation
Signed-off-by: Steven Crespo <[email protected]>
Signed-off-by: Steven Crespo <[email protected]>
Signed-off-by: Steven Crespo <[email protected]>
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
Signed-off-by: Steven Crespo <[email protected]>
Signed-off-by: Steven Crespo <[email protected]>
Signed-off-by: Steven Crespo <[email protected]>
Signed-off-by: Steven Crespo <[email protected]>
Signed-off-by: Steven Crespo <[email protected]>
Signed-off-by: Steven Crespo <[email protected]>
| // If there's none skip the remainder of the test | ||
| if loopbackInterface == nil { | ||
| t.Skip("no loopback interface found on system") | ||
| return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added this to address a golangci-lint error in Sanitize
Signed-off-by: Steven Crespo <[email protected]>
Signed-off-by: Steven Crespo <[email protected]>
…mespace-named-appslug
Signed-off-by: Steven Crespo <[email protected]>
Signed-off-by: Steven Crespo <[email protected]>
Signed-off-by: Steven Crespo <[email protected]>
Signed-off-by: Steven Crespo <[email protected]>
Signed-off-by: Steven Crespo <[email protected]>
Signed-off-by: Steven Crespo <[email protected]>
Signed-off-by: Steven Crespo <[email protected]>
Signed-off-by: Steven Crespo <[email protected]>
Signed-off-by: Steven Crespo <[email protected]>
Signed-off-by: Steven Crespo <[email protected]>
Signed-off-by: Steven Crespo <[email protected]>
Signed-off-by: Steven Crespo <[email protected]>
What this PR does / why we need it:
Changes the namespace of the kots and app deployment from "kotsadm" to the app's slug for new installations in V3. During upgrades, the "kotsadm" namespace is used if it exists, otherwise the app's slug.
Which issue(s) this PR fixes:
https://app.shortcut.com/replicated/story/109550/deploy-kots-and-app-to-namespace-named-appslug-instead-of-kotsadm
Does this PR require a test?
yes
Does this PR require a release note?
Does this PR require documentation?
NONE