Skip to content

bump to nix:2.11.0, use full name for images #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

bump to nix:2.11.0, use full name for images #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40eca80
bump to nix:2.11.0, use full name for images
lizelive Aug 30, 2022
283f0c6
Update ghcr.yaml
lizelive Aug 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ghcr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ on:
- 'master'
tags:
- 'v*'
workflow_dispatch:
pull_request:
branches:
- 'master'
Expand Down
4 changes: 2 additions & 2 deletions bootstrap.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
ARG GOLANG_IMAGE=golang:1.17.5-alpine@sha256:4918412049183afe42f1ecaf8f5c2a88917c2eab153ce5ecf4bf2d55c1507b74
ARG NIX_IMAGE=nixos/nix:2.6.0@sha256:f085a81ca39642a405b41f45e8c21a369d89c65ca9f05d3a9b78dc5852d300ff
ARG GOLANG_IMAGE=docker.io/golang:1.17.5-alpine@sha256:4918412049183afe42f1ecaf8f5c2a88917c2eab153ce5ecf4bf2d55c1507b74
ARG NIX_IMAGE=docker.io/nixos/nix:2.11.0@sha256:ef91f7bb5ef25d95b8a0437ce0ee5d1de5cfdf8ac882f1597f785068ea1e28af
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to use full name?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some systems don't assume docker.io as default

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, what systems? It seems to me that at this point the ship has sailed and refs like this should be interpreted as docker.io for any system to be compatible with the world. As awkward as it is to couple tooling to particular hosts.


FROM ${GOLANG_IMAGE} AS build
WORKDIR /src
Expand Down