Skip to content

Link up new prepareRename command #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 12, 2025
Merged

Link up new prepareRename command #1124

merged 3 commits into from
Sep 12, 2025

Conversation

zth
Copy link
Member

@zth zth commented Sep 6, 2025

Depends on this being released (and the check being adjusted to whatever version it is released in): rescript-lang/rescript#7847

@zth zth requested a review from nojaf September 12, 2025 11:25
nojaf
nojaf approved these changes Sep 12, 2025
View reviewed changes
Copy link
Member

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point, we probably want to rethink all the

  semver.satisfies(rescriptVersion, ">=12.0.0-beta.10", {
        includePrerelease: true,
      });

calls.

@zth
Copy link
Member Author

zth commented Sep 12, 2025

Yeah definitely.

@zth zth merged commit 3d9a6d9 into master Sep 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojaf nojaf nojaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zth @nojaf